From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
Boqun Feng <boqun.feng@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC] workqueue: Fix irq inversion deadlock in manage_workers()
Date: Mon, 9 Oct 2017 08:29:59 -0700 [thread overview]
Message-ID: <20171009152959.GE3301751@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20171009152449.yrqcdhvldgptt4zb@hirez.programming.kicks-ass.net>
Hello,
On Mon, Oct 09, 2017 at 05:24:49PM +0200, Peter Zijlstra wrote:
> So I think we did something similar to the rt_mutex in:
>
> b4abf91047cf ("rtmutex: Make wait_lock irq safe")
>
> And I would not be entirely against doing the same for our normal mutex,
> but I've not really had time to read/think through this thread.
We may want to do that if there are other more valid cases but this
workqueue one shouldn't be the reason. It's something which shouldn't
have been a mutex from the get-go.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-10-09 15:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 9:02 [RFC] workqueue: Fix irq inversion deadlock in manage_workers() Boqun Feng
2017-10-08 19:03 ` Tejun Heo
2017-10-09 3:24 ` Boqun Feng
2017-10-09 6:42 ` Peter Zijlstra
2017-10-09 13:07 ` Tejun Heo
2017-10-09 9:40 ` Lai Jiangshan
2017-10-09 12:40 ` Boqun Feng
2017-10-09 15:24 ` Peter Zijlstra
2017-10-09 15:29 ` Tejun Heo [this message]
2017-10-09 13:21 ` [PATCH workqueue/for-4.14-fixes] workqueue: replace pool->manager_arb mutex with a flag Tejun Heo
2017-10-09 14:21 ` Boqun Feng
2017-10-09 14:47 ` Tejun Heo
2017-10-09 15:02 ` Lai Jiangshan
2017-10-09 15:08 ` Tejun Heo
2017-10-09 15:14 ` Lai Jiangshan
2017-10-09 15:33 ` Tejun Heo
2017-10-09 15:04 ` [PATCH v2 " Tejun Heo
2017-10-10 9:55 ` Lai Jiangshan
2017-10-10 14:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009152959.GE3301751@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=josef@toxicpanda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox