From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755034AbdJIPeE (ORCPT ); Mon, 9 Oct 2017 11:34:04 -0400 Received: from mail-qt0-f176.google.com ([209.85.216.176]:52628 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754982AbdJIPeA (ORCPT ); Mon, 9 Oct 2017 11:34:00 -0400 X-Google-Smtp-Source: AOwi7QDvk+xqtp78rEsuecR+TotpraE86VDEs1G+yl23alTa7Lb6B2NL6qnQg8Iv6J/yvNMGMnNqbg== Date: Mon, 9 Oct 2017 08:33:56 -0700 From: Tejun Heo To: Lai Jiangshan Cc: Boqun Feng , LKML , Josef Bacik , Peter Zijlstra Subject: Re: [PATCH workqueue/for-4.14-fixes] workqueue: replace pool->manager_arb mutex with a flag Message-ID: <20171009153356.GF3301751@devbig577.frc2.facebook.com> References: <20171008090225.27034-1-boqun.feng@gmail.com> <20171009132104.GZ3301751@devbig577.frc2.facebook.com> <20171009150808.GD3301751@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Lai. On Mon, Oct 09, 2017 at 11:14:20PM +0800, Lai Jiangshan wrote: > > wait_event_lock_irq() drops the lock if the condition is not met > > before going to sleep (otherwise it wouldn't be able to sleep). > > I think just using get_pwq()/put_pwq() in manage_workers() > as the following said is simpler than using wait_event_lock_irq() Hmm... let's stay with the current implementation for the fix as it's more straight-forward. We can simplify it later if that'd be worthwhile. Thanks. -- tejun