From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754941AbdJIRjv (ORCPT ); Mon, 9 Oct 2017 13:39:51 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35782 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754293AbdJIRjt (ORCPT ); Mon, 9 Oct 2017 13:39:49 -0400 X-Google-Smtp-Source: AOwi7QCgSuvu3f9aiNXoxhwxic8z4D9cVL14MHl3/7DZ2zKXby9aJCdRrbYo7H92BLEmtoXyvw4Sag== Date: Mon, 9 Oct 2017 10:39:46 -0700 From: Dmitry Torokhov To: Christos Gkekas Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: synaptics-rmi4: Clean up redundant check Message-ID: <20171009173946.GB19253@dtor-ws> References: <1507501611-16703-1-git-send-email-chris.gekas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1507501611-16703-1-git-send-email-chris.gekas@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 08, 2017 at 11:26:51PM +0100, Christos Gkekas wrote: > Variable size_presence_reg·is unsigned so checking whether it is less > than zero is redundant. > > Signed-off-by: Christos Gkekas I'd rather we kept the check as it documents the valid range of values. > --- > drivers/input/rmi4/rmi_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c > index 4f2bb59..68fcb30 100644 > --- a/drivers/input/rmi4/rmi_driver.c > +++ b/drivers/input/rmi4/rmi_driver.c > @@ -601,7 +601,7 @@ int rmi_read_register_desc(struct rmi_device *d, u16 addr, > return ret; > ++addr; > > - if (size_presence_reg < 0 || size_presence_reg > 35) > + if (size_presence_reg > 35) > return -EIO; > > memset(buf, 0, sizeof(buf)); > -- > 2.7.4 > Thanks. -- Dmitry