From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754695AbdJIS3G (ORCPT ); Mon, 9 Oct 2017 14:29:06 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:59221 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbdJIS3E (ORCPT ); Mon, 9 Oct 2017 14:29:04 -0400 Date: Mon, 9 Oct 2017 11:29:00 -0700 From: Darren Hart To: Andy Shevchenko Cc: Colin King , Vadim Pasternak , Andy Shevchenko , Platform Driver , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static Message-ID: <20171009182900.GH12321@fury> References: <20171005104211.30440-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 07, 2017 at 05:03:41PM +0300, Andy Shevchenko wrote: > On Thu, Oct 5, 2017 at 1:42 PM, Colin King wrote: > > From: Colin Ian King > > > > The structures mlxplat_dev and mlxplat_hotplug are local to the source > > and do not need to be in global scope, so make them static. > > > > Cleans up sparse warnings: > > symbol 'mlxplat_dev' was not declared. Should it be static? > > symbol 'mlxplat_hotplug' was not declared. Should it be static? > > Thanks for the patch. > Since Vadim did some rather big driver changes I would like to hear > from him how to proceed with this one: either I apply it now, or after > we get Vadim's series in. I'll be working with Vadim's series shortly and would like to take this after that is settled. -- Darren Hart VMware Open Source Technology Center