From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756004AbdJJDvk (ORCPT ); Mon, 9 Oct 2017 23:51:40 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35331 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754906AbdJJDvi (ORCPT ); Mon, 9 Oct 2017 23:51:38 -0400 X-Google-Smtp-Source: AOwi7QDa/NZqxBAlhkXCDu6UsxHaWQDK6F1Mplw6Ul+p9ab1wPJxpnhoVs9jrF/xeHtx7b28GswLcA== Date: Mon, 9 Oct 2017 20:51:35 -0700 From: Dmitry Torokhov To: Benjamin Tissoires Cc: Andrew Duggan , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Kamil =?iso-8859-1?Q?P=E1ral?= Subject: Re: [PATCH] Input: synaptics - Disable kernel tracking on SMBus devices Message-ID: <20171010035135.GB4601@dtor-ws> References: <1506629239-5940-1-git-send-email-aduggan@synaptics.com> <20170929080844.GA14877@mail.corp.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170929080844.GA14877@mail.corp.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 29, 2017 at 10:08:44AM +0200, Benjamin Tissoires wrote: > On Sep 28 2017 or thereabouts, Andrew Duggan wrote: > > In certain situations kernel tracking seems to be getting confused > > and incorrectly reporting the slot of a contact. On example is when > > the user does a three finger click or tap and then places two fingers > > on the touchpad in the same area. The kernel tracking code seems to > > continue to think that there are three contacts on the touchpad and > > incorrectly alternates the slot of one of the contacts. The result that > > is the input subsystem reports a stream of button press and release > > events as the reported slot changes. > > > > Kernel tracking was originally enabled to prevent cursor jumps, but it > > is unclear how much of an issue kernel jumps actually are. This patch > > simply disabled kernel tracking for now. > > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1482640 > > > > Signed-off-by: Andrew Duggan > > Tested-by: Kamil Páral > > Acked-by: Benjamin Tissoires > > Thanks Andrew for the patch! Applied, thank you. > > Cheers, > Benjamin > > > --- > > drivers/input/mouse/synaptics.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > > index 5af0b7d..ee5466a 100644 > > --- a/drivers/input/mouse/synaptics.c > > +++ b/drivers/input/mouse/synaptics.c > > @@ -1709,8 +1709,7 @@ static int synaptics_create_intertouch(struct psmouse *psmouse, > > .sensor_pdata = { > > .sensor_type = rmi_sensor_touchpad, > > .axis_align.flip_y = true, > > - /* to prevent cursors jumps: */ > > - .kernel_tracking = true, > > + .kernel_tracking = false, > > .topbuttonpad = topbuttonpad, > > }, > > .f30_data = { > > -- > > 2.7.4 > > -- Dmitry