From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756041AbdJJJNG (ORCPT ); Tue, 10 Oct 2017 05:13:06 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:45462 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755819AbdJJJNE (ORCPT ); Tue, 10 Oct 2017 05:13:04 -0400 X-Google-Smtp-Source: AOwi7QBut5fZZdjNZ9T96+g68jkE+H2kSiA0I2JYWm0o3io9zx3vtxEBJSddIOt0iZ8EZL7sjDOCng== Date: Tue, 10 Oct 2017 14:43:01 +0530 From: Viresh Kumar To: Jesper Nilsson Cc: "rjw@sisk.pl" , "linaro-kernel@lists.linaro.org" , "patches@linaro.org" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jesper Nilsson , Mikael Starvik , linux-cris-kernel Subject: Re: [PATCH 07/34] cpufreq: cris: remove calls to cpufreq_notify_transition() Message-ID: <20171010091301.GH4031@vireshk-i7> References: <20171010075742.GL17578@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171010075742.GL17578@axis.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10-10-17, 09:57, Jesper Nilsson wrote: > On Fri, Aug 16, 2013 at 04:25:04AM +0200, Viresh Kumar wrote: > > Most of the drivers do following in their ->target_index() routines: > > > > struct cpufreq_freqs freqs; > > freqs.old = old freq... > > freqs.new = new freq... > > > > cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); > > > > /* Change rate here */ > > > > cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE); > > > > This is replicated over all cpufreq drivers today and there doesn't exists a > > good enough reason why this shouldn't be moved to cpufreq core instead. > > > > Earlier patches have added support in cpufreq core to do cpufreq notification on > > frequency change, this one removes it from this driver. > > > > Some related minor cleanups are also done along with it. > > > > Acked-by: Jesper Nilsson Wow.. You just Acked a 4 years old patch :) -- viresh