From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
hanjun.guo@linaro.org, sudeep.holla@arm.com, rjw@rjwysocki.net,
lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines
Date: Tue, 10 Oct 2017 11:24:36 +0100 [thread overview]
Message-ID: <20171010102436.GA949@red-moon> (raw)
In-Reply-To: <59DC93FE.2060004@huawei.com>
On Tue, Oct 10, 2017 at 05:33:50PM +0800, Hanjun Guo wrote:
> On 2017/9/25 15:24, Arvind Yadav wrote:
> > pr_err() messages should terminated with a new-line to avoid
> > other messages being concatenated onto the end.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> > changes in v2:
> > Add changelog.
> >
> > drivers/acpi/arm64/gtdt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> > index 597a737..92f9edf 100644
> > --- a/drivers/acpi/arm64/gtdt.c
> > +++ b/drivers/acpi/arm64/gtdt.c
> > @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
> > struct acpi_gtdt_timer_entry *gtdt_frame;
> >
> > if (!block->timer_count) {
> > - pr_err(FW_BUG "GT block present, but frame count is zero.");
> > + pr_err(FW_BUG "GT block present, but frame count is zero.\n");
> > return -ENODEV;
> > }
> >
>
> Make sense to me,
>
> Acked-by: Hanjun Guo <hanjun.guo@linaro.org>
>
> Lorenzo, could you pick this up for 4.15?
Sure, thanks for reminding.
Thanks,
Lorenzo
prev parent reply other threads:[~2017-10-10 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 6:45 [PATCH] acpi/arm64: pr_err() strings should end with newlines Arvind Yadav
2017-10-10 9:33 ` [PATCH v2] " Hanjun Guo
2017-10-10 10:24 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010102436.GA949@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=guohanjun@huawei.com \
--cc=hanjun.guo@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox