From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756155AbdJJMbt (ORCPT ); Tue, 10 Oct 2017 08:31:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:52731 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754894AbdJJMbr (ORCPT ); Tue, 10 Oct 2017 08:31:47 -0400 Date: Tue, 10 Oct 2017 14:31:45 +0200 From: Petr Mladek To: Joe Lawrence Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , Jessica Yu , Jiri Kosina , Miroslav Benes Subject: Re: [PATCH v2] livepatch: unpatch all klp_objects if klp_module_coming fails Message-ID: <20171010123145.GC15129@pathway.suse.cz> References: <1506959808-23838-1-git-send-email-joe.lawrence@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506959808-23838-1-git-send-email-joe.lawrence@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2017-10-02 11:56:48, Joe Lawrence wrote: > When an incoming module is considered for livepatching by > klp_module_coming(), it iterates over multiple patches and multiple > kernel objects in this order: > > list_for_each_entry(patch, &klp_patches, list) { > klp_for_each_object(patch, obj) { > > which means that if one of the kernel objects fails to patch, > klp_module_coming()'s error path needs to unpatch and cleanup any kernel > objects that were already patched by a previous patch. > > Reported-by: Miroslav Benes > Suggested-by: Petr Mladek > Signed-off-by: Joe Lawrence Looks good to me. Reviewed-by: Petr Mladek Best Regards, Petr