From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932159AbdJJN7N (ORCPT ); Tue, 10 Oct 2017 09:59:13 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35813 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755688AbdJJN7L (ORCPT ); Tue, 10 Oct 2017 09:59:11 -0400 X-ME-Sender: X-Sasl-enc: bZ6i4zP/w8S+Aa9XTcPYpNTHLpVfUYJ3nUmjKetEy5mZ 1507643950 Date: Tue, 10 Oct 2017 15:59:20 +0200 From: Greg KH To: Mario Limonciello Cc: dvhart@infradead.org, Andy Shevchenko , LKML , platform-driver-x86@vger.kernel.org, Andy Lutomirski , quasisec@google.com, pali.rohar@gmail.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de Subject: Re: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface Message-ID: <20171010135920.GD8662@kroah.com> References: <411980beb5697e312145ef268516f4cc7c585b8f.1507589249.git.mario.limonciello@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <411980beb5697e312145ef268516f4cc7c585b8f.1507589249.git.mario.limonciello@dell.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 09, 2017 at 05:51:52PM -0500, Mario Limonciello wrote: > + ret = device_create_file(&wdev->dev, &priv->req_buf_size_attr); > + if (ret) > + goto fail_create_sysfs; Why isn't the "WMI core" creating this sysfs file? Why have per-driver sysfs files, making all of the different apis totally different? It's a "common" attribute that they are all going to have to provide, right? That way you also don't race with userspace :) thanks, greg k-h