From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756455AbdJJS0o (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Oct 2017 14:26:44 -0400
Received: from mail-pf0-f171.google.com ([209.85.192.171]:55004 "EHLO
        mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755946AbdJJS0m (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Oct 2017 14:26:42 -0400
X-Google-Smtp-Source: AOwi7QBsImddjYmLeImt3+ByADp3OHM0j77Qi9UevMDSzx3wza5q/UvLyVxO58J0aKRzgRO30Yi5AA==
Date: Tue, 10 Oct 2017 11:26:38 -0700
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Ohad Ben-Cohen <ohad@wizery.com>, linux-remoteproc@vger.kernel.org,
        linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] rpmsg: glink: keep balance of mutex locks in
 qcom_glink_request_intent()
Message-ID: <20171010182638.GL20643@builder>
References: <1507325037-20889-1-git-send-email-khoroshilov@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1507325037-20889-1-git-send-email-khoroshilov@ispras.ru>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri 06 Oct 14:23 PDT 2017, Alexey Khoroshilov wrote:

> If qcom_glink_tx() fails in qcom_glink_request_intent(),
> it returns immediately leaving intent_req_lock mutex locked.
> So the next tries to send intent request lead to deadlock.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Thanks Alexey.

This was found by Dan Carpenter a few weeks ago, but I failed to send
the pull request for it, will do so now.

Regards,
Bjorn