From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932575AbdJJTB5 (ORCPT ); Tue, 10 Oct 2017 15:01:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60780 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932087AbdJJTB4 (ORCPT ); Tue, 10 Oct 2017 15:01:56 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 27F94272C2 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=rkrcmar@redhat.com Date: Tue, 10 Oct 2017 21:01:53 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Brijesh Singh Subject: Re: [PATCH] KVM: SVM: limit kvm_handle_page_fault to #PF handling Message-ID: <20171010190152.GB28763@flask> References: <1507625383-23795-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1507625383-23795-1-git-send-email-pbonzini@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 10 Oct 2017 19:01:56 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-10-10 10:49+0200, Paolo Bonzini: > It has always annoyed me a bit how SVM_EXIT_NPF is handled by > pf_interception. This is also the only reason behind the > under-documented need_unprotect argument to kvm_handle_page_fault. > Let NPF go straight to kvm_mmu_page_fault, just like VMX > does in handle_ept_violation and handle_ept_misconfig. > > Signed-off-by: Paolo Bonzini > --- And we also drop the unneeded pv async_pf switch, Reviewed-by: Radim Krčmář