From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755974AbdJJTQT (ORCPT ); Tue, 10 Oct 2017 15:16:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42036 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753792AbdJJTQR (ORCPT ); Tue, 10 Oct 2017 15:16:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A641E81E1C Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=rkrcmar@redhat.com Date: Tue, 10 Oct 2017 21:16:15 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: x86: extend usage of RET_MMIO_PF_* constants Message-ID: <20171010191614.GC28763@flask> References: <1507626659-28195-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1507626659-28195-1-git-send-email-pbonzini@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 10 Oct 2017 19:16:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-10-10 11:10+0200, Paolo Bonzini: > The x86 MMU if full of code that returns 0 and 1 for retry/emulate. Use > the existing RET_MMIO_PF_RETRY/RET_MMIO_PF_EMULATE enum, renaming it to > drop the MMIO part. > > Signed-off-by: Paolo Bonzini > --- > diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h > @@ -788,7 +788,7 @@ static int FNAME(page_fault)(struct kvm_vcpu *vcpu, gva_t addr, u32 error_code, > > if (try_async_pf(vcpu, prefault, walker.gfn, addr, &pfn, write_fault, > &map_writable)) > - return 0; > + return RET_PF_RETRY; > > if (handle_abnormal_pfn(vcpu, addr, walker.gfn, pfn, walker.pte_access, &r)) > return r; > @@ -833,7 +833,7 @@ static int FNAME(page_fault)(struct kvm_vcpu *vcpu, gva_t addr, u32 error_code, > out_unlock: > spin_unlock(&vcpu->kvm->mmu_lock); > kvm_release_pfn_clean(pfn); > - return 0; > + return RET_PF_EMULATE; A direct conversion would return RET_PF_RETRY, is this some optimization? Apart from that, Reviewed-by: Radim Krčmář Thanks.