From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756528AbdJJXbW (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Oct 2017 19:31:22 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35035 "EHLO
        out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753369AbdJJXbU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Oct 2017 19:31:20 -0400
X-ME-Sender: <xms:SFjdWUzG5lpBbMh1fL6irlr_KSKH1lS-22uwi0l6xDO5IrfC_ULSuQ>
X-Sasl-enc: J3xnP3doLYh731Rr0orst/gppeAMk0AT+HASqNjYocDp 1507678279
Date: Wed, 11 Oct 2017 10:31:16 +1100
From: "Tobin C. Harding" <me@tobin.cc>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "kernel-hardening@lists.openwall.com" 
        <kernel-hardening@lists.openwall.com>,
        KVM list <kvm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Kees Cook <keescook@chromium.org>, Paolo Bonzini <pbonzini@redhat.com>,
        Tycho Andersen <tycho@docker.com>,
        "Roberts, William C" <william.c.roberts@intel.com>,
        Tejun Heo <tj@kernel.org>,
        Jordan Glover <Golden_Miller83@protonmail.ch>,
        Greg KH <gregkh@linuxfoundation.org>, Petr Mladek <pmladek@suse.com>,
        Joe Perches <joe@perches.com>, Ian Campbell <ijc@hellion.org.uk>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>, Chris Fries <cfries@google.com>,
        Dave Weinstein <olorin@google.com>,
        Daniel Micay <danielmicay@gmail.com>,
        Djalal Harouni <tixxdz@gmail.com>
Subject: Re: [PATCH 0/3] add %pX specifier
Message-ID: <20171010233116.GA2049@eros>
References: <1507676974-1298-1-git-send-email-me@tobin.cc>
 <CA+55aFyH5X2nx0kf_hPeOjMQYF-UX6r3ov61=VqTOLLZLE3-vQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFyH5X2nx0kf_hPeOjMQYF-UX6r3ov61=VqTOLLZLE3-vQ@mail.gmail.com>
X-Mailer: Mutt 1.5.24 (2015-08-30)
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 10, 2017 at 04:16:55PM -0700, Linus Torvalds wrote:
> On Tue, Oct 10, 2017 at 4:09 PM, Tobin C. Harding <me@tobin.cc> wrote:
> >
> > This patch is a softer version of Linus' suggestion because it does not change the behaviour of the
> > %p specifier. I don't see the benefit in making such a breaking change without addressing the issue
> > of %x (and I don't the balls to right now).
> 
> The thing is, this continues to have the exact same issue that %pK has
> - because it is opt-in, effectively nobody will actually use it.
> 
> That's why I would suggest that if we do this way, we really change %p
> and %pa to use the hashed value, to convert *everybody*. And then
> people who have a good reason to actually expose the pointer have to
> do the extra work and opt out.
> 
>                   Linus

Righto, I'll wait 24 hours and submit v2 with the change as suggested. I guess now is as good a time
as any annoy everybody and cause them to do work (for the greater good :)

Then I can direct effort at finding any users of %x for kernel addresses.

thanks,
Tobin.