Re: [PATCH v2] Staging: bcm2048 fix bare use of 'unsigned' in radio-bcm2048.c

Tobin C. Harding
2017-10-10T23:42:55Z

Hi Branislav,

On Tue, Oct 10, 2017 at 03:29:19PM +0200, Branislav Radocaj wrote:
> This is a patch to the radio-bcm2048.c file that fixes up
> a warning found by the checkpatch.pl tool.
>
> Signed-off-by: Branislav Radocaj <branislav@radocaj.org>

Nice work, a few git log nit picks for you to ensure your future kernel development success.

You can read all this in Documentaton/process/submitting-patches.rst (section 2).

- You can use imperative mood, i.e 'Fix foo by doing bar' instead of 'This patch ...'
- We don't need to mention the file (either in the summary or in the body), people can see this from
the diff.

This is one way of writing the git log message for checkpatch fixes

checkpatch emits WARNING: EXPORT_SYMBOL(foo); should immediately follow
its function/variable.

Move EXPORT_SYMBOL macro call to immediately follow function definition.

Good work, hope this helps.

Tobin