From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbdJLDUU (ORCPT ); Wed, 11 Oct 2017 23:20:20 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42076 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753270AbdJLDUR (ORCPT ); Wed, 11 Oct 2017 23:20:17 -0400 Date: Wed, 11 Oct 2017 20:20:16 -0700 (PDT) Message-Id: <20171011.202016.1730207765050552906.davem@davemloft.net> To: colin.king@canonical.com Cc: dsahern@gmail.com, rshearma@brocade.com, roopa@cumulusnetworks.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][net-next] net: mpls: make function ipgre_mpls_encap_hlen static From: David Miller In-Reply-To: <20171011095328.17546-1-colin.king@canonical.com> References: <20171011095328.17546-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Oct 2017 20:20:16 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 11 Oct 2017 10:53:28 +0100 > From: Colin Ian King > > The function ipgre_mpls_encap_hlen is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'ipgre_mpls_encap_hlen' was not declared. Should it be static? > > Signed-off-by: Colin Ian King Applied, thanks Colin.