public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	LKP <lkp@01.org>, Josh Poimboeuf <jpoimboe@redhat.com>,
	kernel-team@lge.com
Subject: Re: [lockdep] b09be676e0 BUG: unable to handle kernel NULL pointer dereference at 000001f2
Date: Wed, 11 Oct 2017 11:36:36 +0900	[thread overview]
Message-ID: <20171011023635.GI3323@X58A-UD3R> (raw)
In-Reply-To: <CA+55aFxqRb_rK8Fa_b8zL+jg3p43w81zkt5iWpFFfByY6Rx6vg@mail.gmail.com>

On Tue, Oct 10, 2017 at 09:56:26AM -0700, Linus Torvalds wrote:
> On Tue, Oct 10, 2017 at 9:22 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > I really would like to see the sites that do cross-thread lock/unlock
> > pairs themselves be annotated.
> >
> > So when you lock in one thread, and then unlock in another, I'd
> > actually prefer to see something like
> >
> >  - T1:
> >         lock_mutex_cross();
> >
> >  - T2:
> >         unlock_mutex_cross();
> >
> > to make it very explicit that *these* particular lock/unlock
> > operations are the fancy ones.
> 
> Actually, let's make it even *more* obvious, and even easier for
> lockdep (and for humans) to see what's going on.
> 
> So I think the best model would be something like this:
> 
>  - T1:
>         mutex_lock(&lock)
>         ...
>         mutex_transfer(&lock)
> 
>  - T2:
>         mutex_receive(&lock);
>         ...
>         mutex_unlock(&lock);

In addition, if we really need to use mutex locks in this way, I also
think it should work with the explicit primitives as you said.

  parent reply	other threads:[~2017-10-11  2:36 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 14:06 [lockdep] b09be676e0 BUG: unable to handle kernel NULL pointer dereference at 000001f2 Fengguang Wu
2017-10-03 14:31 ` Josh Poimboeuf
2017-10-03 14:41   ` Josh Poimboeuf
2017-10-03 15:05     ` Josh Poimboeuf
2017-10-03 16:28       ` Josh Poimboeuf
2017-10-03 17:34         ` Josh Poimboeuf
2017-10-03 21:44           ` Tetsuo Handa
2017-10-04 21:06             ` Josh Poimboeuf
2017-10-04 21:30               ` Linus Torvalds
2017-10-04 22:15                 ` Josh Poimboeuf
2017-10-04 22:40             ` Josh Poimboeuf
2017-10-05 11:02               ` Tetsuo Handa
2017-10-05 13:57                 ` Josh Poimboeuf
2017-10-04  8:34       ` Peter Zijlstra
2017-10-10  5:57         ` Byungchul Park
2017-10-03 16:54 ` Linus Torvalds
2017-10-03 16:57   ` Linus Torvalds
2017-10-10  5:48     ` Byungchul Park
2017-10-10 16:22       ` Linus Torvalds
2017-10-10 16:56         ` Linus Torvalds
2017-10-10 18:14           ` Peter Zijlstra
2017-10-10 18:38             ` Linus Torvalds
2017-10-11  1:14             ` Byungchul Park
2017-10-11  2:36           ` Byungchul Park [this message]
2017-10-11  0:56         ` Byungchul Park
2017-10-11  1:02           ` Byungchul Park
2017-10-12  1:15           ` Byungchul Park
2017-10-03 17:18   ` Ingo Molnar
2017-10-04  9:20     ` Peter Zijlstra
2017-10-04 10:31       ` Ingo Molnar
2017-10-04 14:15       ` Josh Poimboeuf
2017-10-10  5:30     ` Byungchul Park
2017-10-05 13:01   ` Josh Poimboeuf
2017-10-05 14:54     ` Josh Poimboeuf
2017-10-09 10:50       ` Peter Zijlstra
2017-10-09 12:21         ` Fengguang Wu
2017-10-09 12:54           ` Peter Zijlstra
2017-10-09 12:59             ` Fengguang Wu
2017-10-09 13:03             ` Josh Poimboeuf
2017-10-09 12:55           ` Fengguang Wu
2017-10-09 13:26             ` Josh Poimboeuf
2017-10-09 14:17               ` Fengguang Wu
2017-10-09 15:28                 ` Peter Zijlstra
2017-10-09 15:41                   ` Fengguang Wu
2017-10-09 15:44                     ` Peter Zijlstra
2017-10-09 15:47                       ` Fengguang Wu
2017-10-10  5:08   ` Byungchul Park
2017-10-12  8:47 ` Peter Zijlstra
2017-10-12  9:21   ` Fengguang Wu
2017-10-12  9:28     ` Fengguang Wu
2017-10-12 11:45       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011023635.GI3323@X58A-UD3R \
    --to=byungchul.park@lge.com \
    --cc=fengguang.wu@intel.com \
    --cc=jpoimboe@redhat.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox