From: Johan Hovold <johan@kernel.org>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status
Date: Wed, 11 Oct 2017 09:45:01 +0200 [thread overview]
Message-ID: <20171011074501.GQ4269@localhost> (raw)
In-Reply-To: <20171010201041.GA1464@embeddedor.com>
On Tue, Oct 10, 2017 at 03:10:41PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Johan Hovold <johan@kernel.org>
Patch is fine, but next time make sure to run scripts/get_maintainer.sh
to figure which people and lists to CC.
We also try to include the module (component) "es2" in the commit
summary (unless you really are doing things subsystem wide), although
that has not been enforced for staging clean ups recently.
Thanks,
Johan
next prev parent reply other threads:[~2017-10-11 7:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 20:10 [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status Gustavo A. R. Silva
2017-10-11 7:45 ` Johan Hovold [this message]
2017-10-11 15:12 ` Gustavo A. R. Silva
2017-10-11 16:06 ` Joe Perches
2017-10-11 16:34 ` Gustavo A. R. Silva
2017-10-11 16:08 ` Johan Hovold
2017-10-11 16:31 ` Gustavo A. R. Silva
2017-10-12 9:05 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011074501.GQ4269@localhost \
--to=johan@kernel.org \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox