From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753027AbdJKNEY (ORCPT ); Wed, 11 Oct 2017 09:04:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:48178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbdJKNEX (ORCPT ); Wed, 11 Oct 2017 09:04:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA05F21874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 11 Oct 2017 09:04:20 -0400 From: Steven Rostedt To: Jiri Olsa Cc: Peter Zijlstra , mingo@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, zhouchengming1@huawei.com Subject: Re: [PATCH 2/4] perf/ftrace: Fix function trace events Message-ID: <20171011090420.2bb1d29c@gandalf.local.home> In-Reply-To: <20171011115954.GA7940@krava> References: <20171011074528.764500836@infradead.org> <20171011080224.257804988@infradead.org> <20171011115954.GA7940@krava> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Oct 2017 13:59:54 +0200 Jiri Olsa wrote: > > @@ -330,7 +354,7 @@ perf_ftrace_function_call(unsigned long > > entry->ip = ip; > > entry->parent_ip = parent_ip; > > perf_trace_buf_submit(entry, ENTRY_SIZE, rctx, TRACE_FN, > > - 1, ®s, head, NULL); > > + 1, ®s, &head, NULL); > > nice idea.. I'll test it After you test it, want me to take this through my tree? Also, we should address zhouchengming's concerns. -- Steve