From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752174AbdJKOXN (ORCPT ); Wed, 11 Oct 2017 10:23:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43831 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbdJKOXM (ORCPT ); Wed, 11 Oct 2017 10:23:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com EC79C7F3FB Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Wed, 11 Oct 2017 16:23:09 +0200 From: Jiri Olsa To: Steven Rostedt Cc: Peter Zijlstra , mingo@kernel.org, linux-kernel@vger.kernel.org, jolsa@kernel.org, zhouchengming1@huawei.com Subject: Re: [PATCH 2/4] perf/ftrace: Fix function trace events Message-ID: <20171011142309.GC8306@krava> References: <20171011074528.764500836@infradead.org> <20171011080224.257804988@infradead.org> <20171011115954.GA7940@krava> <20171011090420.2bb1d29c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171011090420.2bb1d29c@gandalf.local.home> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 11 Oct 2017 14:23:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2017 at 09:04:20AM -0400, Steven Rostedt wrote: > On Wed, 11 Oct 2017 13:59:54 +0200 > Jiri Olsa wrote: > > > > @@ -330,7 +354,7 @@ perf_ftrace_function_call(unsigned long > > > entry->ip = ip; > > > entry->parent_ip = parent_ip; > > > perf_trace_buf_submit(entry, ENTRY_SIZE, rctx, TRACE_FN, > > > - 1, ®s, head, NULL); > > > + 1, ®s, &head, NULL); > > > > nice idea.. I'll test it > > After you test it, want me to take this through my tree? peter's call ;-) > Also, we should address zhouchengming's concerns. agreed.. I tested and it looks ok to me jirka