Re: [PATCH 02/35] perf annotate: Add annotation_line struct

[Jiri Olsa <jolsa@redhat.com>]

On Wed, Oct 11, 2017 at 12:29:42PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 11, 2017 at 05:01:25PM +0200, Jiri Olsa escreveu:
> > In order to make the annotation support generic, I'm adding
> > 'struct annotation_line', which will hold all generic data
> > common to any annotation source (it's coming on following
> > patches). Having this, we can add different annotation
> > line support than objdump disasm.
> 
> Such as? What other "annotation line support" other than "objdump
> disasm"?

such a python script.. sent in the email earlier

jirka


---
 Percent |      Source code & Disassembly of [python_stack] for cycles:ppp (50 samples)
 [_parse /usr/lib64/python3.6/sre_parse.py] 
---------------------------------------------------------------------------------------
         :                    # parse a simple pattern
    0.00 :   5584195c1600:    subpattern = SubPattern(state)
         :
         :                    # precompute constants into local variables
    2.00 :   5584195c1608:    subpatternappend = subpattern.append
    0.00 :   5584195c160e:    sourceget = source.get
    2.00 :   5584195c1614:    sourcematch = source.match
    0.00 :   5584195c161a:    _len = len
    0.00 :   5584195c161e:    _ord = ord
         :
    0.00 :   5584195c1622:    while True:
         :
    6.00 :   5584195c1626:        this = source.next
    4.00 :   5584195c162c:        if this is None:
    0.00 :   5584195c1634:            break # end of pattern
    2.00 :   5584195c1636:        if this in "|)":
    0.00 :   5584195c163e:            break # end of subpattern
   10.00 :   5584195c1640:        sourceget()
         :
    4.00 :   5584195c1646:        if verbose:
         :                            # skip whitespace and comments
    4.00 :   5584195c164a:            if this in WHITESPACE:
...