From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757624AbdJKTn2 (ORCPT ); Wed, 11 Oct 2017 15:43:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:43218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360AbdJKTn1 (ORCPT ); Wed, 11 Oct 2017 15:43:27 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E92C421902 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 11 Oct 2017 16:43:23 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Jiri Olsa , lkml , Ingo Molnar , Namhyung Kim , David Ahern , Peter Zijlstra , Andi Kleen Subject: Re: [PATCH 00/35] perf annotate: Use generic annotation line Message-ID: <20171011194323.GI3503@kernel.org> References: <20171011150158.11895-1-jolsa@kernel.org> <20171011152709.GC3503@kernel.org> <20171011191057.GA18184@krava> <20171011191859.GH3503@kernel.org> <20171011193005.GC18184@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171011193005.GC18184@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Oct 11, 2017 at 09:30:05PM +0200, Jiri Olsa escreveu: > On Wed, Oct 11, 2017 at 04:18:59PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Oct 11, 2017 at 09:10:57PM +0200, Jiri Olsa escreveu: > > > On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > > > > > I'm working on script profiling support and came up > > > > Can you describe what you mean by "script profiling" and "script > > > > annotation"? > > > I have some prototype code that allows to get the > > > internal script stack to the sample and display > > What is an "internal script stack"? Ah, looking further below you mean > > "python scripts", I see! > yep, the stack/callchain inside script ;-) only python so far > > Please try to state what you want to achieve in a detailed way as you go > > writing the patches, that eases reviewing, not requiring us to go > > looking at _all_ the patches in a series to then figure out and restart > > reviewing patch by patch... > > well I think the annotation patches i sent can stand on their own > and also I did not want to send it all in 50+ patches bomb Yeah, but understanding what you want to get to helps in reviewing, anyway, now I know :-) - Arnaldo