From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776AbdJKVY6 (ORCPT ); Wed, 11 Oct 2017 17:24:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42082 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbdJKVYz (ORCPT ); Wed, 11 Oct 2017 17:24:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ACEF0C047B69 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=marcelo.leitner@gmail.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com ACEF0C047B69 Date: Wed, 11 Oct 2017 18:24:51 -0300 From: Marcelo Ricardo Leitner To: Joe Perches Cc: Colin King , Vlad Yasevich , Neil Horman , "David S . Miller" , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] sctp: make array sctp_sched_ops static Message-ID: <20171011212451.GA4454@localhost.localdomain> References: <20171011101757.18825-1-colin.king@canonical.com> <1507718690.3552.50.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507718690.3552.50.camel@perches.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 11 Oct 2017 21:24:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2017 at 03:44:50AM -0700, Joe Perches wrote: > On Wed, 2017-10-11 at 11:17 +0100, Colin King wrote: > > From: Colin Ian King > > > > The array sctp_sched_ops is local to the source and > > does not need to be in global scope, so make it static. > > > > Cleans up sparse warning: > > symbol 'sctp_sched_ops' was not declared. Should it be static? > > > > Signed-off-by: Colin Ian King > > --- > > net/sctp/stream_sched.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/sctp/stream_sched.c b/net/sctp/stream_sched.c > > index 03513a9fa110..0b83ec51e43b 100644 > > --- a/net/sctp/stream_sched.c > > +++ b/net/sctp/stream_sched.c > > @@ -124,7 +124,7 @@ static struct sctp_sched_ops sctp_sched_fcfs = { > > extern struct sctp_sched_ops sctp_sched_prio; > > extern struct sctp_sched_ops sctp_sched_rr; > > > > -struct sctp_sched_ops *sctp_sched_ops[] = { > > +static struct sctp_sched_ops *sctp_sched_ops[] = { > > &sctp_sched_fcfs, > > &sctp_sched_prio, > > &sctp_sched_rr, > > Perhaps these should also be const to move more data to text Yes. There are no plans on supporting any sort of dynamic updates on this, at least for now. Marcelo