From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbdJLJFz (ORCPT ); Thu, 12 Oct 2017 05:05:55 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:50181 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751340AbdJLJFx (ORCPT ); Thu, 12 Oct 2017 05:05:53 -0400 X-Google-Smtp-Source: ABhQp+QMUPlYGzYAbA1gu7AnaJn5ECz17bNSW9eDPTTbfX/sClyNTMTaDQx5rU4dnvN3kmbE43uj7w== Date: Thu, 12 Oct 2017 11:05:53 +0200 From: Johan Hovold To: "Gustavo A. R. Silva" Cc: Johan Hovold , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status Message-ID: <20171012090553.GI4269@localhost> References: <20171010201041.GA1464@embeddedor.com> <20171011074501.GQ4269@localhost> <20171011101250.Horde.ShAACqxWq_0okyS3bLhkOF7@gator4166.hostgator.com> <20171011160815.GA2655@localhost> <20171011113107.Horde.iB4g8uGTQZ4zFqy_7M5EF95@gator4166.hostgator.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171011113107.Horde.iB4g8uGTQZ4zFqy_7M5EF95@gator4166.hostgator.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2017 at 11:31:07AM -0500, Gustavo A. R. Silva wrote: > Quoting Johan Hovold : > > > On Wed, Oct 11, 2017 at 10:12:50AM -0500, Gustavo A. R. Silva wrote: > >> Hi Johan, > >> > >> Quoting Johan Hovold : > > > >> > Patch is fine, but next time make sure to run scripts/get_maintainer.sh > >> > to figure which people and lists to CC. > >> > > >> > >> I actually did: > >> > >> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback > >> drivers/staging/greybus/es2.c > >> > >> and this was the output: > >> > >> linux-kernel@vger.kernel.org (open list) > I double checked and this is what happened: > > $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback > drivers//staging/greybus/es2.c > > Notice that double slash after drivers: // Ah, perhaps something which should be supported. > >> > We also try to include the module (component) "es2" in the commit > >> > summary (unless you really are doing things subsystem wide), although > >> > that has not been enforced for staging clean ups recently. > >> > > >> > >> I got it. I'll take that into account for future patches. > > > > Looking at the commit history for the file in questions usually gives a > > hint about the style used for the corresponding subsystem. > > > > Yep, I usually do that: > > $ git log --oneline drivers/staging/greybus/es2.c > > This time I got many of these two: > > staging: greybus: > greybus: es2: > > so I picked up the first one. > > But I get your point and I understand now that I should have used the > second one. Good, so you already have the habit of doing so. As I mentioned, this file in staging is not the best example since the prefix has changed over time and not really been enforced lately (it should really be "staging: greybus: es2" now). Thanks, Johan