[PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[Gustavo A. R. Silva]

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/staging/greybus/es2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index f7b24e0..e451c2f 100644
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -761,6 +761,7 @@ static int check_urb_status(struct urb *urb)
 	case -EOVERFLOW:
 		dev_err(dev, "%s: overflow actual length is %d\n",
 			__func__, urb->actual_length);
+		/* fall through */
 	case -ECONNRESET:
 	case -ENOENT:
 	case -ESHUTDOWN:
-- 
2.7.4

Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[Johan Hovold]

On Tue, Oct 10, 2017 at 03:10:41PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Acked-by: Johan Hovold <johan@kernel.org>

Patch is fine, but next time make sure to run scripts/get_maintainer.sh
to figure which people and lists to CC.

We also try to include the module (component) "es2" in the commit
summary (unless you really are doing things subsystem wide), although
that has not been enforced for staging clean ups recently.

Thanks,
Johan

Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[Gustavo A. R. Silva]

Hi Johan,

Quoting Johan Hovold <johan@kernel.org>:

> On Tue, Oct 10, 2017 at 03:10:41PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Acked-by: Johan Hovold <johan@kernel.org>
>
> Patch is fine, but next time make sure to run scripts/get_maintainer.sh
> to figure which people and lists to CC.
>

I actually did:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers/staging/greybus/es2.c

and this was the output:

linux-kernel@vger.kernel.org (open list)

> We also try to include the module (component) "es2" in the commit
> summary (unless you really are doing things subsystem wide), although
> that has not been enforced for staging clean ups recently.
>

I got it. I'll take that into account for future patches.

Thanks
--
Gustavo A. R. Silva

Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[Joe Perches]

On Wed, 2017-10-11 at 10:12 -0500, Gustavo A. R. Silva wrote:
> Hi Johan,
> 
> Quoting Johan Hovold <johan@kernel.org>:
> 
> > On Tue, Oct 10, 2017 at 03:10:41PM -0500, Gustavo A. R. Silva wrote:
> > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > > where we are expecting to fall through.
> > > 
> > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> > 
> > Acked-by: Johan Hovold <johan@kernel.org>
> > 
> > Patch is fine, but next time make sure to run scripts/get_maintainer.sh
> > to figure which people and lists to CC.
> > 
> 
> I actually did:
> 
> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
> drivers/staging/greybus/es2.c
> 
> and this was the output:
> 
> linux-kernel@vger.kernel.org (open list)

I don't know how that happens.

$ ./scripts/get_maintainer.pl -f --nokeywords --nogit --nogit-fallback drivers/staging/greybus/es2.c
Johan Hovold <johan@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
Alex Elder <elder@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:GREYBUS SUBSYSTEM)
greybus-dev@lists.linaro.org (moderated list:GREYBUS SUBSYSTEM)
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[Gustavo A. R. Silva]

Hi Joe,

Quoting Joe Perches <joe@perches.com>:

> On Wed, 2017-10-11 at 10:12 -0500, Gustavo A. R. Silva wrote:
>> Hi Johan,
>>
>> Quoting Johan Hovold <johan@kernel.org>:
>>
>> > On Tue, Oct 10, 2017 at 03:10:41PM -0500, Gustavo A. R. Silva wrote:
>> > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> > > where we are expecting to fall through.
>> > >
>> > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> >
>> > Acked-by: Johan Hovold <johan@kernel.org>
>> >
>> > Patch is fine, but next time make sure to run scripts/get_maintainer.sh
>> > to figure which people and lists to CC.
>> >
>>
>> I actually did:
>>
>> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
>> drivers/staging/greybus/es2.c
>>
>> and this was the output:
>>
>> linux-kernel@vger.kernel.org (open list)
>
> I don't know how that happens.
>
> $ ./scripts/get_maintainer.pl -f --nokeywords --nogit  
> --nogit-fallback drivers/staging/greybus/es2.c
> Johan Hovold <johan@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
> Alex Elder <elder@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:GREYBUS  
> SUBSYSTEM)
> greybus-dev@lists.linaro.org (moderated list:GREYBUS SUBSYSTEM)
> devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)

I was running this command:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers//staging/greybus/es2.c

instead of this one:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers/staging/greybus/es2.c

Thanks
--
Gustavo A. R. Silva

Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[Johan Hovold]

On Wed, Oct 11, 2017 at 10:12:50AM -0500, Gustavo A. R. Silva wrote:
> Hi Johan,
> 
> Quoting Johan Hovold <johan@kernel.org>:

> > Patch is fine, but next time make sure to run scripts/get_maintainer.sh
> > to figure which people and lists to CC.
> >
> 
> I actually did:
> 
> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
> drivers/staging/greybus/es2.c
> 
> and this was the output:
> 
> linux-kernel@vger.kernel.org (open list)

Very odd. If I run the exact same command I get the expected result:

Johan Hovold <johan@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
Alex Elder <elder@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:GREYBUS SUBSYSTEM)
greybus-dev@lists.linaro.org (moderated list:GREYBUS SUBSYSTEM)
devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

> > We also try to include the module (component) "es2" in the commit
> > summary (unless you really are doing things subsystem wide), although
> > that has not been enforced for staging clean ups recently.
> >
> 
> I got it. I'll take that into account for future patches.

Looking at the commit history for the file in questions usually gives a
hint about the style used for the corresponding subsystem.

Thanks,
Johan

Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[Gustavo A. R. Silva]

Quoting Johan Hovold <johan@kernel.org>:

> On Wed, Oct 11, 2017 at 10:12:50AM -0500, Gustavo A. R. Silva wrote:
>> Hi Johan,
>>
>> Quoting Johan Hovold <johan@kernel.org>:
>
>> > Patch is fine, but next time make sure to run scripts/get_maintainer.sh
>> > to figure which people and lists to CC.
>> >
>>
>> I actually did:
>>
>> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
>> drivers/staging/greybus/es2.c
>>
>> and this was the output:
>>
>> linux-kernel@vger.kernel.org (open list)
>
> Very odd. If I run the exact same command I get the expected result:
>
> Johan Hovold <johan@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
> Alex Elder <elder@kernel.org> (maintainer:GREYBUS SUBSYSTEM)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:GREYBUS  
> SUBSYSTEM)
> greybus-dev@lists.linaro.org (moderated list:GREYBUS SUBSYSTEM)
> devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
>

I double checked and this is what happened:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers//staging/greybus/es2.c

Notice that double slash after drivers: //

For some reason I was running that command instead of this one:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers/staging/greybus/es2.c

>> > We also try to include the module (component) "es2" in the commit
>> > summary (unless you really are doing things subsystem wide), although
>> > that has not been enforced for staging clean ups recently.
>> >
>>
>> I got it. I'll take that into account for future patches.
>
> Looking at the commit history for the file in questions usually gives a
> hint about the style used for the corresponding subsystem.
>

Yep, I usually do that:

$ git log --oneline drivers/staging/greybus/es2.c

This time I got many of these two:

staging: greybus:
greybus: es2:

so I picked up the first one.

But I get your point and I understand now that I should have used the  
second one.

Thanks
--
Gustavo A. R. Silva

Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[Johan Hovold]

On Wed, Oct 11, 2017 at 11:31:07AM -0500, Gustavo A. R. Silva wrote:
> Quoting Johan Hovold <johan@kernel.org>:
> 
> > On Wed, Oct 11, 2017 at 10:12:50AM -0500, Gustavo A. R. Silva wrote:
> >> Hi Johan,
> >>
> >> Quoting Johan Hovold <johan@kernel.org>:
> >
> >> > Patch is fine, but next time make sure to run scripts/get_maintainer.sh
> >> > to figure which people and lists to CC.
> >> >
> >>
> >> I actually did:
> >>
> >> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
> >> drivers/staging/greybus/es2.c
> >>
> >> and this was the output:
> >>
> >> linux-kernel@vger.kernel.org (open list)

> I double checked and this is what happened:
> 
> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
> drivers//staging/greybus/es2.c
> 
> Notice that double slash after drivers: //

Ah, perhaps something which should be supported.

> >> > We also try to include the module (component) "es2" in the commit
> >> > summary (unless you really are doing things subsystem wide), although
> >> > that has not been enforced for staging clean ups recently.
> >> >
> >>
> >> I got it. I'll take that into account for future patches.
> >
> > Looking at the commit history for the file in questions usually gives a
> > hint about the style used for the corresponding subsystem.
> >
> 
> Yep, I usually do that:
> 
> $ git log --oneline drivers/staging/greybus/es2.c
> 
> This time I got many of these two:
> 
> staging: greybus:
> greybus: es2:
> 
> so I picked up the first one.
> 
> But I get your point and I understand now that I should have used the  
> second one.

Good, so you already have the habit of doing so. As I mentioned, this
file in staging is not the best example since the prefix has changed
over time and not really been enforced lately (it should really be
"staging: greybus: es2" now).

Thanks,
Johan