From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbdJLCiD (ORCPT ); Wed, 11 Oct 2017 22:38:03 -0400 Received: from mail-bl2nam02on0054.outbound.protection.outlook.com ([104.47.38.54]:44448 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751794AbdJLCiB (ORCPT ); Wed, 11 Oct 2017 22:38:01 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; Date: Thu, 12 Oct 2017 10:35:47 +0800 From: Jisheng Zhang To: Jin Qian Cc: Ulf Hansson , Jin Qian , Shawn Lin , Adrian Hunter , Linus Walleij , Jaehoon Chung , Uri Yanai , Chanho Min , Jungseung Lee , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCHv2 1/1] ANDROID: mmc: core: export emmc revision Message-ID: <20171012103547.27b415ca@xhacker.debian> In-Reply-To: <20171011205152.173299-1-jinqian@android.com> References: <20171011205152.173299-1-jinqian@android.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Originating-IP: [124.74.246.114] X-ClientProxiedBy: SG2PR06CA0089.apcprd06.prod.outlook.com (10.170.138.15) To BY2PR0301MB0759.namprd03.prod.outlook.com (10.160.63.27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 160e8b57-a83d-4d71-af46-08d5111a3f16 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BY2PR0301MB0759; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0759;3:T6Cxxxa0HRD+WhxdK/oid1JcwtY+Epj8QoWVPUxJMQ+Jf2vbsTIfsULFqKf1yi9WyGXhOr0sxL9XQ+YQuedA5fiU6OYXr8go2DxtCfhrjBy5yPhcVThb1aJnz8zQxhOBHgdFUQqLG6p4RASSfTRTjGX2LFKEqrlYxEl9dOBmdNcdAltbzIZHLrOPpJAURgvCx5SXEv89HBTYWocXTSdYae0rp88KBFOjgUZR01ieqadwoGiKwHsTIPv7FNW77IBr;25:2na05iR1pxo3WtxI5uLVpB5LndUmFAwwQKGJ2eMqWHGySz+pZB3WB/omJTfcNx6E4SibHP2+2LmaEbyZw4Pdv+O84Cym414c1m97eKqA938fLy0NREmGS4a+vjPwIsV3MbJmhNBz/qQALAwkfqR7gR4zniwz1znauIhnd46sYFYvDLdOoCVyy6psykzEc51EcR+iOlpC26Z0u5Bit4kkjdC9JcXLJ3fTiMyUEQ4fU6sOZIukiYEKtGaSlo8Vsb7O5F/OmZy4dLgVjjMvZp64AtpQYmU5lyLsYVCqgKqaFuRZN1icCXJ252nr7/+nNlm85wsVPVAY7lH9Cjn6itV67iMQlsDidD4o+cdkuTlfo4M=;31:gNTqySDZbHKgGEfcol5IVcPleGjl3KSpo6t37EMBIvTEpmP/9EpgWnkEGWxsSGJx4sXUwFigmSfQqMP3cHkZmSaEu3+2yiDDtrg4KchE2qbNyeq3qCTDBhJQWkLpQX0V26H/CtkpuwUSRE20v3/K5HKiT/NANcLtbv8MjsZbMncYlfZOo9v8wUj8ATDIfmx5tMBR0tW1WOJIkeqFi3RiNEIc+5KFyVhSYGfDUMpvjso= X-MS-TrafficTypeDiagnostic: BY2PR0301MB0759: X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0759;20:Xdmss7XTrkJ840FUy9tmhzTcNjkEcJIMsMzbx5Pq+H2UAiwpMZkugVr2/7ov7lYHMP3Xg6BLmB902J65UMPQGuGEMaBvwTJi/arE/PjG4mAsYYn72OhAXBst28FH+5dwsaegOJDfD7+MFCMmGO4j8cgo+V1dni/79BzwMAIeGcvOMbuYPs5d73IpJP1t4tlBMpxO5UaAgAYz5OKIHRkOh64gTMFF0IVBQP8IsNZo95p9nKLPT+LQYUu8Y4lizMtSzJ1i2Y8+oubPhgJJ3BI9WewARKryxkci4BODRbw737WU+RiZBxHYFCz/jXKg0DQpOp9NG0+K4j4Tc1yjRSsPnRfvPcw0/RYYfzml+hEOMz/bbuz7DVHkBTSy4bSxoYSZJC4NHw8R3uh+qIlyNfibfcVP5CGlZl15O3APhNqm4nc=;4:jFZBEXjzmbHfVFdnnEmxW0GmjwJ08FN+9b4xiIRHD2l9ID4dtgof0YVhUFRtyZ9xtgEVV7b8Q0adDo5k2AYRz1ZSOqd9p+btTHRP0WMJQB3nnSFxobSamv7SHRGRLIYshLR/6a4Fy/u21ujDTSVUGYPRmNqfUFbbKSQLD54DmsZ53BRbt5UwoHDKYUD35zBGlpcyMwdV9qQdJvq3NMcFK7VR9yDXXAmdWXQo96yoTaMx9ZfZcpaBJ4w/iMfLOxJXMSi4bIOl6e58fyzI8pQe5KTpX2nb7enP7MuPEJAiPVHvQRcn1KnZdvgWpzEajOI2as5nrNZO6SttyX6X2CyoAw== X-Exchange-Antispam-Report-Test: UriScan:(211936372134217)(153496737603132); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(920507026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR0301MB0759;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR0301MB0759; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(199003)(189002)(50944005)(24454002)(229853002)(25786009)(34040400001)(316002)(23726003)(2950100002)(47776003)(105586002)(33646002)(6916009)(6506006)(86362001)(5660300001)(66066001)(106356001)(1076002)(305945005)(7736002)(8936002)(68736007)(101416001)(97736004)(7416002)(81166006)(81156014)(50226002)(6666003)(8676002)(54906003)(72206003)(8656003)(189998001)(53936002)(50466002)(6116002)(16526018)(76176999)(50986999)(2906002)(478600001)(55016002)(6246003)(3846002)(4326008)(9686003)(230700001)(39210200001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0301MB0759;H:xhacker.debian;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR0301MB0759;23:gjoO8U1bCLjfqHHQG4KL2CRLrlXeQ77F+F31EdR?= =?us-ascii?Q?02eQJ1VM0ZFvF5Rr7QMVosD7qQiIxNPAKcIDqFpqB/9lC/ELSJa2tR3EgKM6?= =?us-ascii?Q?d7iYXYjhUh2cDCRfKyntKmQXtrJICjoRpKkeuTuQyeqiq41FvAHcYuOBXnE6?= =?us-ascii?Q?HiVAY4AuZ+vIeWwgykcFsIfuvP9MQQH3RC1SZcx7MH/pAEOEWMzzC/5HWVzO?= =?us-ascii?Q?v6T94ybXCI7EhX2tz+aFyfcUbfbmh7wwZ/MJeP2/QS1mCvq8+jtCLtEo92HA?= =?us-ascii?Q?5BwgwYx1mtQRGVTUWa+SYVd8/HoO1IkLy1enyhl6sNVnEG7Nzm+VoGtscg/d?= =?us-ascii?Q?VVxjI8/BWm3F0M0fVp17jUluYZhdSHLi35IxZDkee2LNvNB0W69ikT8O4tXb?= =?us-ascii?Q?Ze6xVTu8pDUtm+Gwag6O22CcjTssqNbwWBMiPfqXDsY8qfJINge3L0syeIXk?= =?us-ascii?Q?w1Jq3MBqlYCarhkNbkYfiIGGLm1LsgQMzs9aKzF2g/DzEX0k6V/PLZLT6tSO?= =?us-ascii?Q?E+tOdkdTuAftZyJdQPV/4/iBFpin4fsb3jrEN+u84FThmGz3hojFbenpc8e/?= =?us-ascii?Q?a9csnpw4fGLHN9jldborZprqYYo+d2AARQKPm47Or1Qwep+aQl/OqbZ6Z2Kk?= =?us-ascii?Q?FeNg0RGwviehz7bUjXm6oy8rDmC+E2amZTmmxVZ6dloPdC9XnMYjEBXONyDz?= =?us-ascii?Q?hk3HeycgCSyXdeHTjA5wjx9fdHQKydbORM5fjni3lJswAajTZxe6hPgSJRZH?= =?us-ascii?Q?7NwT6uaVKK3iE9xtN+M+1iPUFVD7iSFDvL4xDoTNNgFQ16YJ6v3WKjw/NWW5?= =?us-ascii?Q?gLAb/nvGDd0+3yA8+7jP4If34iqud4qO1iJKGw1sd7tB9sEjqy9VTZS0nAOS?= =?us-ascii?Q?K35FhzW84QCuu1H519Pnd6niUKcQRbhWqmMRe/qq0a8rQQo1ovU7o+KTMf3G?= =?us-ascii?Q?M0KtVVRM5x1Jq4TSckQ0OIrCg7VH966ffh4K6VtOmRjqRkQxmXwkFg4OPAhO?= =?us-ascii?Q?JSNnhBZylVNdMCXWN941fg22oh430MIv64rpe8GyTiYCo0B5NHtO95ZALV5C?= =?us-ascii?Q?LZOtOd8cojAjXE69v7ZyGN35DA1SBE+msOfuVMxoPXCJNajKIfFCNhyaqmQK?= =?us-ascii?Q?uo2Z9CBIcl2AvL3KjyelP/L6roo0LOzcf1KxucybN2W8V83um1+7Trji03VM?= =?us-ascii?Q?TWBRPi7JfqwAk6qKooKcR5VTT+OSydgJ7tc4hWIU8FOR6atc/MtI1KRTSlvA?= =?us-ascii?Q?y99fBt6PxeE1oyS02vZM=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0759;6:GiWVgiL0Rv3728WM7cJiSPxjsx5VGdTE9GsvlsAiYFdnz/HCTtLfjnR4Ppwg4Gp2JBH6z7aoFq/8k/v7QwqJjCaJ8T87Fv5u8mLfi144rVbeVE1PuuRmopVAsDWfi9OqObe3wIq2JvR2NNG5f2wP++OrGKFgJhNg0FFChoAESDFayAVcv9Ni1JzauYnRMCFEF+HHUOLWeGJbZpSNY30fiGjgl4cTlsgPQE1MgKoZKKV26GBLkioBanLTqRM48atXiLoyH+MYNwhT8jkKVYF3g3sp7wX/zndW/VYSdrbErqBvLHGoc5UMiPWgw9yBHbS8pfEl7yK25e9MZIkYpUxJ9A==;5:K366YIzD205CcL7z4qP+6H+9GySyW6qx0f3DhypDHn3xn8LAtLyu7VqOVKaQ8PbbsegeiPNCm0SAKISezMaX5DidrEsF5DHUT42UklES/l6ZU11so5J/8VN0aetSAN/wvbaD+L5HPwPwt5zlRsDVf3AKlex/hhuqPMDQGPsQXf0=;24:VAAaOR9wAE1+Mp3WyY4n6v6sjosg02Jr7SQK3SXGPGvE4McIMxkdugFkiWX7abBdyMyH7uP8neHOxZ0J/XdYP8HsZnk3IZ+cacopvCxKYdc=;7:/abU8LzPvS1BMyKR/luyDk5Fk+fLjHOfOptaY1U9thmR1ohzaI/yZmVSPAlxbw0CMGITfS1ChxczfmbSUrEywwapuwBiYgp1etMOgRsftGj2fTVqhSgAGoClv2cOgL7z4NIx5JRWcV5iV2/D714EkK0LbMxS/crMWNjVvLiwCUiqiuxatnmdJWmHu0YCyleHuMBeXOiEoorApfGls7CNNNCiMZdcedQcyLG9mkGLT38= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 02:37:53.2755 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0759 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Oct 2017 13:51:26 -0700 Jin Qian wrote: > From: Jin Qian > > Expose emmc revision as part of device attributes. >> ANDROID: mmc: core: export emmc revision This commit probably back port from android linux kernel repo. Could we remove the ANDROID prefix > > Signed-off-by: Jin Qian > --- > Documentation/ABI/testing/sysfs-bus-mmc | 4 ++++ > drivers/mmc/core/mmc.c | 2 ++ > 2 files changed, 6 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-mmc > > diff --git a/Documentation/ABI/testing/sysfs-bus-mmc b/Documentation/ABI/testing/sysfs-bus-mmc > new file mode 100644 > index 000000000000..519f028d19cc > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-mmc > @@ -0,0 +1,4 @@ > +What: /sys/bus/mmc/devices/.../rev > +Date: October 2017 > +Contact: Jin Qian > +Description: Extended CSD revision number > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index 36217ad5e9b1..4aa4cfb2c9e1 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -780,6 +780,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid); > MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name); > MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid); > MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv); > +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev); > MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info); > MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n", > card->ext_csd.device_life_time_est_typ_a, > @@ -838,6 +839,7 @@ static struct attribute *mmc_std_attrs[] = { > &dev_attr_name.attr, > &dev_attr_oemid.attr, > &dev_attr_prv.attr, > + &dev_attr_rev.attr, > &dev_attr_pre_eol_info.attr, > &dev_attr_life_time.attr, > &dev_attr_serial.attr,