From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbdJLOBC (ORCPT ); Thu, 12 Oct 2017 10:01:02 -0400 Received: from mga04.intel.com ([192.55.52.120]:8266 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752212AbdJLOBA (ORCPT ); Thu, 12 Oct 2017 10:01:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,366,1503385200"; d="scan'208";a="322476122" Date: Thu, 12 Oct 2017 19:35:05 +0530 From: Vinod Koul To: Colin King Cc: Dan Williams , Maxime Coquelin , Alexandre Torgue , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][dma-next] dmaengine: stm32: remove redundant initialization of hwdesc Message-ID: <20171012140505.GP30097@localhost> References: <20171011102822.19166-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171011102822.19166-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2017 at 11:28:22AM +0100, Colin King wrote: > From: Colin Ian King > > hwdesc is being initialized to desc->hwdesc but this is never read > as hwdesc is overwritten in a for-loop. Remove the redundant > initialization and move the declaration of hwdesc into the for-loop. > > Cleans up clang warning: > Value stored to 'hwdesc' during its initialization is never read Applied, thanks -- ~Vinod