From: Al Viro <viro@ZenIV.linux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicolas Pitre <nico@linaro.org>, Ingo Molnar <mingo@kernel.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mickael GUENE <mickael.guene@st.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] elf_fdpic: fix unused variable warning
Date: Thu, 12 Oct 2017 16:34:57 +0100 [thread overview]
Message-ID: <20171012153456.GE21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20171012153158.2840511-1-arnd@arndb.de>
On Thu, Oct 12, 2017 at 05:31:46PM +0200, Arnd Bergmann wrote:
> The elf_fdpic code shows a harmless warning when built with MMU disabled,
> I ran into this now that fdpic is available on ARM randconfig builds
> since commit 50b2b2e691cd ("ARM: add ELF_FDPIC support").
>
> fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments':
> fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable]
>
> This adds another #ifdef around the variable declaration to shut up
> the warning.
>
> Fixes: e6c1baa9b562 ("convert the rest of binfmt_elf_fdpic to dump_emit()")
> Acked-by: Nicolas Pitre <nico@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied...
next prev parent reply other threads:[~2017-10-12 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 15:31 [PATCH] elf_fdpic: fix unused variable warning Arnd Bergmann
2017-10-12 15:34 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-12 9:46 Arnd Bergmann
2017-10-12 15:21 ` Nicolas Pitre
2017-10-12 15:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012153456.GE21978@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickael.guene@st.com \
--cc=mingo@kernel.org \
--cc=nico@linaro.org \
--cc=nicolas.pitre@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox