From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbdJLPfE (ORCPT ); Thu, 12 Oct 2017 11:35:04 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:57462 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbdJLPfD (ORCPT ); Thu, 12 Oct 2017 11:35:03 -0400 Date: Thu, 12 Oct 2017 16:34:57 +0100 From: Al Viro To: Arnd Bergmann Cc: Nicolas Pitre , Ingo Molnar , Nicolas Pitre , Frederic Weisbecker , Mickael GUENE , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] elf_fdpic: fix unused variable warning Message-ID: <20171012153456.GE21978@ZenIV.linux.org.uk> References: <20171012153158.2840511-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012153158.2840511-1-arnd@arndb.de> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 05:31:46PM +0200, Arnd Bergmann wrote: > The elf_fdpic code shows a harmless warning when built with MMU disabled, > I ran into this now that fdpic is available on ARM randconfig builds > since commit 50b2b2e691cd ("ARM: add ELF_FDPIC support"). > > fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments': > fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable] > > This adds another #ifdef around the variable declaration to shut up > the warning. > > Fixes: e6c1baa9b562 ("convert the rest of binfmt_elf_fdpic to dump_emit()") > Acked-by: Nicolas Pitre > Signed-off-by: Arnd Bergmann Applied...