Re: [PATCH] elf_fdpic: fix unused variable warning

Arnd Bergmann
2017-10-12T15:27:32Z

On Thu, Oct 12, 2017 at 5:21 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> On Thu, 12 Oct 2017, Arnd Bergmann wrote:
>
>> The elf_fdpic code shows a harmless warning when built with MMU
>> enabled, I ran into this now that the configuration is possible
>> on ARM randconfig builds:
>>
>> fs/binfmt_elf_fdpic.c: In function 'elf_fdpic_dump_segments':
>> fs/binfmt_elf_fdpic.c:1501:17: error: unused variable 'addr' [-Werror=unused-variable]
>
> In fact the warning appears when built *without* MMU.

Ah, of course.

>> Who should pick this up? I guess it could go through either the
>> ARM tree that introduced the warning for ARM and contains a number
>> of fdpic patches, or it could go through the VFS tree.
>
> Given the above I'd say the VFS tree.

Ok, I'll create a new version, thanks for taking a look.

Arnd