From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbdJLP7q (ORCPT ); Thu, 12 Oct 2017 11:59:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60104 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbdJLP7p (ORCPT ); Thu, 12 Oct 2017 11:59:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0203F78EB0 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Thu, 12 Oct 2017 17:59:42 +0200 From: Jiri Olsa To: "Wangnan (F)" Cc: Arnaldo Carvalho de Melo , Andi Kleen , Jiri Olsa , linux-kernel@vger.kernel.org, Andi Kleen , He Kuang , Alexei Starovoitov Subject: Re: [PATCH 2/2] perf, tools: Don't force MetricExprs to lower case Message-ID: <20171012155942.GA15716@krava> References: <20170912195643.2611-1-andi@firstfloor.org> <20170912195643.2611-2-andi@firstfloor.org> <20171003160605.GC25388@kernel.org> <20171004103052.GC23759@krava> <20171004162711.GF2482@two.firstfloor.org> <20171009134151.GA15127@krava> <20171009140728.GG2482@two.firstfloor.org> <20171009141258.GE28623@kernel.org> <20171009143953.GA1561@krava> <5d8fc047-1535-5308-91b5-577d8ead1d28@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d8fc047-1535-5308-91b5-577d8ead1d28@huawei.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 12 Oct 2017 15:59:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 11:31:51PM +0800, Wangnan (F) wrote: SNIP > > > > Ok. If it works it's fine for me. > > well it works, but it means that bpf file cannot contains any directory > > part.. which im not sure is ok with bpf folks ;-) anyone? > > Sorry I didn't see this thread these days. > > Do you think adding a special escape character to suppress BPF > name parsing in a event is a good idea? for example: > > % perf stat -e cpu/uops_executed.core,cmask=1/ true > bpf: builtin compilation failed: -95, try external compiler > ERROR: problems with path cpu/uops_executed.c: No such file or directory > event syntax error: 'cpu/uops_executed.core,cmask=1/' > \___ Failed to load cpu/uops_executed.c from source: > Error when compiling BPF scriptlet. Add a leading '@' to avoid BPF syntax > > % perf stat -e @cpu/uops_executed.core,cmask=1/ true > ... > if we go this way, I'd rather mark the bpf syntax instead of changing the generic event format, like Andi suggested in some earlier email but maybe we can workaround this with patch I sent in my last email thanks, jirka