From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757582AbdJMBtu (ORCPT ); Thu, 12 Oct 2017 21:49:50 -0400 Received: from smtprelay0017.hostedemail.com ([216.40.44.17]:44470 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753427AbdJMBtt (ORCPT ); Thu, 12 Oct 2017 21:49:49 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3872:3873:3874:5007:6119:6120:6261:7514:7875:7901:7903:9108:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12438:12740:12760:12895:13069:13180:13229:13311:13357:13439:14096:14097:14181:14659:14721:21063:21067:21080:21627:30012:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: title12_385655987a830 X-Filterd-Recvd-Size: 2030 Date: Thu, 12 Oct 2017 21:49:45 -0400 From: Steven Rostedt To: Alexei Starovoitov Cc: LKML , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH] tracing: bpf: Hide bpf trace events when they are not used Message-ID: <20171012214945.1fbcba2f@vmware.local.home> In-Reply-To: <20171013013834.pxh3ancgutrm6m7t@ast-mbp> References: <20171012184002.0661a867@gandalf.local.home> <20171013011450.w2uqygdfzwf7ud64@ast-mbp> <20171012213501.17fe6f8c@vmware.local.home> <20171013013834.pxh3ancgutrm6m7t@ast-mbp> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Oct 2017 18:38:36 -0700 Alexei Starovoitov wrote: > actually just noticed that xdp tracepoints are not covered by ifdef. > They depend on bpf_syscall too. So probably makes sense to wrap > them together. > bpf tracepoints are not being actively worked on whereas xdp tracepoints > keep evolving quickly, so the best is probalby to go via net-next > if you don't mind. Hmm, they didn't trigger a warning, with the exception of trace_xdp_redirect_map. I have code to check if tracepoints are used or not, and it appears that the xdp can be used without BPF_SYSCALL. I don't think they should be wrapped together until we know why they are used. I can still take this patch and just not touch the xdp ones. Note, my kernel was using trace_xdp_redirect_map_err, trace_xdp_redirect_err, trace_xdp_redirect and trace_xdp_exception. As they did appear. -- Steve