From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] tracing, rcu: Hide trace event rcu_nocb_wake when not used
Date: Thu, 12 Oct 2017 15:44:41 -0700 [thread overview]
Message-ID: <20171012224441.GP3521@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171012181641.2461934d@gandalf.local.home>
On Thu, Oct 12, 2017 at 06:16:41PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> The trace event rcu_nocb_wake is only used when CONFIG_RCU_NOCB_CPU is
> defined. But the trace event is defined regardless. As defined trace
> events take up memory, it is a waste to have it defined when not used.
> Surround the trace event with an #ifdef to have it only defined when it
> is used.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
And this one applied cleanly, queued for review and testing, thank you!
Thanx, Paul
> ---
> Index: linux-trace.git/include/trace/events/rcu.h
> ===================================================================
> --- linux-trace.git.orig/include/trace/events/rcu.h
> +++ linux-trace.git/include/trace/events/rcu.h
> @@ -242,6 +242,7 @@ TRACE_EVENT(rcu_exp_funnel_lock,
> __entry->grphi, __entry->gpevent)
> );
>
> +#ifdef CONFIG_RCU_NOCB_CPU
> /*
> * Tracepoint for RCU no-CBs CPU callback handoffs. This event is intended
> * to assist debugging of these handoffs.
> @@ -284,6 +285,7 @@ TRACE_EVENT(rcu_nocb_wake,
>
> TP_printk("%s %d %s", __entry->rcuname, __entry->cpu, __entry->reason)
> );
> +#endif
>
> /*
> * Tracepoint for tasks blocking within preemptible-RCU read-side
>
prev parent reply other threads:[~2017-10-12 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 22:16 [PATCH] tracing, rcu: Hide trace event rcu_nocb_wake when not used Steven Rostedt
2017-10-12 22:44 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012224441.GP3521@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox