From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] tracing, rcu: Remove no longer used trace event rcu_prep_idle
Date: Thu, 12 Oct 2017 15:46:17 -0700 [thread overview]
Message-ID: <20171012224617.GQ3521@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171012183239.2dc52914@gandalf.local.home>
On Thu, Oct 12, 2017 at 06:32:39PM -0400, Steven Rostedt wrote:
> On Thu, 12 Oct 2017 15:26:45 -0700
> "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
> > On Thu, Oct 12, 2017 at 06:12:57PM -0400, Steven Rostedt wrote:
> > > From: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > >
> > > Commit c0f4dfd4f90 ("rcu: Make RCU_FAST_NO_HZ take advantage of
> > > numbered callbacks") removed the only instances of trace_rcu_prep_idle,
> > > but did not remove the TRACE_EVENT() that creates it. As defined trace
> > > events take up memory within the kernel even when they are not used,
> > > this is a waste of space. Remove the obsolete event.
> > >
> > > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > Good catch, queued for review and testing, thank you!
> >
> > Slight change in the context of the final hunk of the patch for -rcu,
> > updated version shown below.
>
> I now have a utility that complains when tracepoints are not used. But
> I'm working on getting this to work at build time and not run time. In
> the mean time, I might as well do some clean up ;-)
Well, I just today learned that I am not supposed to be using the %p
printk format option, so been doing a bit of cleaning here as well. ;-)
Thanx, Paul
prev parent reply other threads:[~2017-10-12 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 22:12 [PATCH] tracing, rcu: Remove no longer used trace event rcu_prep_idle Steven Rostedt
2017-10-12 22:26 ` Paul E. McKenney
2017-10-12 22:32 ` Steven Rostedt
2017-10-12 22:46 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012224617.GQ3521@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox