From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756779AbdJLWqX (ORCPT ); Thu, 12 Oct 2017 18:46:23 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50338 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429AbdJLWqV (ORCPT ); Thu, 12 Oct 2017 18:46:21 -0400 Date: Thu, 12 Oct 2017 15:46:17 -0700 From: "Paul E. McKenney" To: Steven Rostedt Cc: LKML , Andrew Morton Subject: Re: [PATCH] tracing, rcu: Remove no longer used trace event rcu_prep_idle Reply-To: paulmck@linux.vnet.ibm.com References: <20171012181257.27c7e3b2@gandalf.local.home> <20171012222645.GO3521@linux.vnet.ibm.com> <20171012183239.2dc52914@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012183239.2dc52914@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17101222-0040-0000-0000-000003B228D4 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007887; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000236; SDB=6.00930265; UDB=6.00468279; IPR=6.00710531; BA=6.00005635; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017513; XFM=3.00000015; UTC=2017-10-12 22:46:18 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101222-0041-0000-0000-000007A72B86 Message-Id: <20171012224617.GQ3521@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-12_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710120320 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 06:32:39PM -0400, Steven Rostedt wrote: > On Thu, 12 Oct 2017 15:26:45 -0700 > "Paul E. McKenney" wrote: > > > On Thu, Oct 12, 2017 at 06:12:57PM -0400, Steven Rostedt wrote: > > > From: Steven Rostedt (VMware) > > > > > > Commit c0f4dfd4f90 ("rcu: Make RCU_FAST_NO_HZ take advantage of > > > numbered callbacks") removed the only instances of trace_rcu_prep_idle, > > > but did not remove the TRACE_EVENT() that creates it. As defined trace > > > events take up memory within the kernel even when they are not used, > > > this is a waste of space. Remove the obsolete event. > > > > > > Signed-off-by: Steven Rostedt (VMware) > > > > Good catch, queued for review and testing, thank you! > > > > Slight change in the context of the final hunk of the patch for -rcu, > > updated version shown below. > > I now have a utility that complains when tracepoints are not used. But > I'm working on getting this to work at build time and not run time. In > the mean time, I might as well do some clean up ;-) Well, I just today learned that I am not supposed to be using the %p printk format option, so been doing a bit of cleaning here as well. ;-) Thanx, Paul