From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753726AbdJMFGc (ORCPT ); Fri, 13 Oct 2017 01:06:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48802 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbdJMFGb (ORCPT ); Fri, 13 Oct 2017 01:06:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AE8E580B22 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Fri, 13 Oct 2017 00:06:30 -0500 From: Josh Poimboeuf To: Kamalesh Babulal Cc: linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH] objtool: Fix memory leak in decode_instructions() Message-ID: <20171013050630.cdax2kxj3yqnaton@treble> References: <1507798934-18140-1-git-send-email-kamalesh@linux.vnet.ibm.com> <20171012161016.z4ytxmm2rbfiewbl@treble> <1297c97f-844b-0631-311d-8e3742f2f74f@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1297c97f-844b-0631-311d-8e3742f2f74f@linux.vnet.ibm.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 13 Oct 2017 05:06:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 13, 2017 at 10:14:36AM +0530, Kamalesh Babulal wrote: > On Thursday 12 October 2017 09:40 PM, Josh Poimboeuf wrote: > > On Thu, Oct 12, 2017 at 02:32:14PM +0530, Kamalesh Babulal wrote: > > > free the allocated insn before returning, when an error occurs > > > before adding insn to file->insn_list. > > > > > > Signed-off-by: Kamalesh Babulal > > > > Any chance you're working on porting objtool to ppc64le? :-) > > > > Acked-by: Josh Poimboeuf > > > > Thanks for the review. I have started working on it :) Good! Let me know if you have any questions. I originally wrote objtool with arch-independence in mind, though with the new "objtool 2.0" rewrite, it unfortunately became more x86-specific. I was hoping to work on making it more arch-independent, and then start porting it to other arches, but it may be a few months before I have the time to do so. So any work you want to there would be great. -- Josh