From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757593AbdJMJeS (ORCPT ); Fri, 13 Oct 2017 05:34:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51592 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbdJMJeR (ORCPT ); Fri, 13 Oct 2017 05:34:17 -0400 Date: Fri, 13 Oct 2017 11:26:59 +0200 From: Greg KH To: rui_feng@realsil.com.cn Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, ricky_wu@realtek.com Subject: Re: [PATCH] staging: rtsx: Add support for RTS5260 Message-ID: <20171013092659.GA28241@kroah.com> References: <1507884635-3134-1-git-send-email-rui_feng@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1507884635-3134-1-git-send-email-rui_feng@realsil.com.cn> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 13, 2017 at 04:50:35PM +0800, rui_feng@realsil.com.cn wrote: > From: rui_feng > > Add support for new chip rts5260. > In order to support rts5260，the definitions of some internal > registers and workflow have to be modified and are different from its > predecessors and OCP function is added for RTS5260. > So we need this patch to ensure RTS5260 can work. > > Signed-off-by: Rui Feng Your from and signed-off-by name does not match :( > --- > drivers/mfd/Makefile | 4 + > drivers/mfd/rtsx_pcr.c | 127 ++++++- > drivers/mfd/rtsx_pcr.h | 12 + > drivers/staging/Kconfig | 2 + > drivers/staging/rts5260/Kconfig | 6 + > drivers/staging/rts5260/rts5260.c | 748 ++++++++++++++++++++++++++++++++++++++ > drivers/staging/rts5260/rts5260.h | 45 +++ > include/linux/mfd/rtsx_pci.h | 234 +++++++++++- I do not see a reason why this is a staging driver. Where is the TODO file listing what needs to be done to get it out of staging? Why can it not just go into the "real" part of the kernel? thanks, greg k-h