From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Jin Qian <jinqian@android.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Jin Qian <jinqian@google.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Uri Yanai <uri.yanai@sandisk.com>,
Chanho Min <chanho.min@lge.com>,
Jungseung Lee <js07.lee@samsung.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCHv3 1/1] mmc: core: export emmc revision
Date: Fri, 13 Oct 2017 14:57:18 +0800 [thread overview]
Message-ID: <20171013145718.390bc4ef@xhacker.debian> (raw)
In-Reply-To: <20171012174703.44680-1-jinqian@android.com>
On Thu, 12 Oct 2017 10:46:59 -0700 Jin Qian wrote:
> From: Jin Qian <jinqian@google.com>
>
> Expose emmc revision as part of device attributes.
>
> Signed-off-by: Jin Qian <jinqian@android.com>
> ---
A trivial point: when you send newer version, could you add change log
so that it's clearly expressed what's updated/addressed.
> Documentation/ABI/testing/sysfs-bus-mmc | 4 ++++
> drivers/mmc/core/mmc.c | 2 ++
> 2 files changed, 6 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-mmc
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-mmc b/Documentation/ABI/testing/sysfs-bus-mmc
> new file mode 100644
> index 000000000000..519f028d19cc
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-mmc
> @@ -0,0 +1,4 @@
> +What: /sys/bus/mmc/devices/.../rev
> +Date: October 2017
> +Contact: Jin Qian <jinqian@android.com>
> +Description: Extended CSD revision number
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 36217ad5e9b1..4aa4cfb2c9e1 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -780,6 +780,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
> MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
> MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
> MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
> MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
> MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
> card->ext_csd.device_life_time_est_typ_a,
> @@ -838,6 +839,7 @@ static struct attribute *mmc_std_attrs[] = {
> &dev_attr_name.attr,
> &dev_attr_oemid.attr,
> &dev_attr_prv.attr,
> + &dev_attr_rev.attr,
> &dev_attr_pre_eol_info.attr,
> &dev_attr_life_time.attr,
> &dev_attr_serial.attr,
next prev parent reply other threads:[~2017-10-13 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 17:46 [PATCHv3 1/1] mmc: core: export emmc revision Jin Qian
2017-10-13 6:57 ` Jisheng Zhang [this message]
2017-10-13 12:38 ` Linus Walleij
2017-10-20 10:02 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013145718.390bc4ef@xhacker.debian \
--to=jisheng.zhang@synaptics.com \
--cc=adrian.hunter@intel.com \
--cc=chanho.min@lge.com \
--cc=jh80.chung@samsung.com \
--cc=jinqian@android.com \
--cc=jinqian@google.com \
--cc=js07.lee@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=uri.yanai@sandisk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox