* [PATCHv3 1/1] mmc: core: export emmc revision
@ 2017-10-12 17:46 Jin Qian
2017-10-13 6:57 ` Jisheng Zhang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jin Qian @ 2017-10-12 17:46 UTC (permalink / raw)
To: Ulf Hansson, Jin Qian, Shawn Lin, Adrian Hunter, Linus Walleij,
Jaehoon Chung, Uri Yanai, Chanho Min, Jungseung Lee, linux-kernel,
linux-mmc
Cc: Jin Qian
From: Jin Qian <jinqian@google.com>
Expose emmc revision as part of device attributes.
Signed-off-by: Jin Qian <jinqian@android.com>
---
Documentation/ABI/testing/sysfs-bus-mmc | 4 ++++
drivers/mmc/core/mmc.c | 2 ++
2 files changed, 6 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-bus-mmc
diff --git a/Documentation/ABI/testing/sysfs-bus-mmc b/Documentation/ABI/testing/sysfs-bus-mmc
new file mode 100644
index 000000000000..519f028d19cc
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-bus-mmc
@@ -0,0 +1,4 @@
+What: /sys/bus/mmc/devices/.../rev
+Date: October 2017
+Contact: Jin Qian <jinqian@android.com>
+Description: Extended CSD revision number
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 36217ad5e9b1..4aa4cfb2c9e1 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -780,6 +780,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
+MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
card->ext_csd.device_life_time_est_typ_a,
@@ -838,6 +839,7 @@ static struct attribute *mmc_std_attrs[] = {
&dev_attr_name.attr,
&dev_attr_oemid.attr,
&dev_attr_prv.attr,
+ &dev_attr_rev.attr,
&dev_attr_pre_eol_info.attr,
&dev_attr_life_time.attr,
&dev_attr_serial.attr,
--
2.15.0.rc0.271.g36b669edcc-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv3 1/1] mmc: core: export emmc revision
2017-10-12 17:46 [PATCHv3 1/1] mmc: core: export emmc revision Jin Qian
@ 2017-10-13 6:57 ` Jisheng Zhang
2017-10-13 12:38 ` Linus Walleij
2017-10-20 10:02 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Jisheng Zhang @ 2017-10-13 6:57 UTC (permalink / raw)
To: Jin Qian
Cc: Ulf Hansson, Jin Qian, Shawn Lin, Adrian Hunter, Linus Walleij,
Jaehoon Chung, Uri Yanai, Chanho Min, Jungseung Lee, linux-kernel,
linux-mmc
On Thu, 12 Oct 2017 10:46:59 -0700 Jin Qian wrote:
> From: Jin Qian <jinqian@google.com>
>
> Expose emmc revision as part of device attributes.
>
> Signed-off-by: Jin Qian <jinqian@android.com>
> ---
A trivial point: when you send newer version, could you add change log
so that it's clearly expressed what's updated/addressed.
> Documentation/ABI/testing/sysfs-bus-mmc | 4 ++++
> drivers/mmc/core/mmc.c | 2 ++
> 2 files changed, 6 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-mmc
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-mmc b/Documentation/ABI/testing/sysfs-bus-mmc
> new file mode 100644
> index 000000000000..519f028d19cc
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-mmc
> @@ -0,0 +1,4 @@
> +What: /sys/bus/mmc/devices/.../rev
> +Date: October 2017
> +Contact: Jin Qian <jinqian@android.com>
> +Description: Extended CSD revision number
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 36217ad5e9b1..4aa4cfb2c9e1 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -780,6 +780,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
> MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
> MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
> MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
> MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
> MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
> card->ext_csd.device_life_time_est_typ_a,
> @@ -838,6 +839,7 @@ static struct attribute *mmc_std_attrs[] = {
> &dev_attr_name.attr,
> &dev_attr_oemid.attr,
> &dev_attr_prv.attr,
> + &dev_attr_rev.attr,
> &dev_attr_pre_eol_info.attr,
> &dev_attr_life_time.attr,
> &dev_attr_serial.attr,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv3 1/1] mmc: core: export emmc revision
2017-10-12 17:46 [PATCHv3 1/1] mmc: core: export emmc revision Jin Qian
2017-10-13 6:57 ` Jisheng Zhang
@ 2017-10-13 12:38 ` Linus Walleij
2017-10-20 10:02 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2017-10-13 12:38 UTC (permalink / raw)
To: Jin Qian
Cc: Ulf Hansson, Jin Qian, Shawn Lin, Adrian Hunter, Jaehoon Chung,
Uri Yanai, Chanho Min, Jungseung Lee,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
On Thu, Oct 12, 2017 at 7:46 PM, Jin Qian <jinqian@android.com> wrote:
> From: Jin Qian <jinqian@google.com>
>
> Expose emmc revision as part of device attributes.
>
> Signed-off-by: Jin Qian <jinqian@android.com>
(...)
> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
This will be 0x0000 on ordinary MMC cards right?
Have you tested it?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv3 1/1] mmc: core: export emmc revision
2017-10-12 17:46 [PATCHv3 1/1] mmc: core: export emmc revision Jin Qian
2017-10-13 6:57 ` Jisheng Zhang
2017-10-13 12:38 ` Linus Walleij
@ 2017-10-20 10:02 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2017-10-20 10:02 UTC (permalink / raw)
To: Jin Qian
Cc: Jin Qian, Shawn Lin, Adrian Hunter, Linus Walleij, Jaehoon Chung,
Uri Yanai, Chanho Min, Jungseung Lee,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
On 12 October 2017 at 19:46, Jin Qian <jinqian@android.com> wrote:
> From: Jin Qian <jinqian@google.com>
>
> Expose emmc revision as part of device attributes.
>
> Signed-off-by: Jin Qian <jinqian@android.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> Documentation/ABI/testing/sysfs-bus-mmc | 4 ++++
> drivers/mmc/core/mmc.c | 2 ++
> 2 files changed, 6 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-mmc
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-mmc b/Documentation/ABI/testing/sysfs-bus-mmc
> new file mode 100644
> index 000000000000..519f028d19cc
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-mmc
> @@ -0,0 +1,4 @@
> +What: /sys/bus/mmc/devices/.../rev
> +Date: October 2017
> +Contact: Jin Qian <jinqian@android.com>
> +Description: Extended CSD revision number
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 36217ad5e9b1..4aa4cfb2c9e1 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -780,6 +780,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
> MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
> MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
> MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
> MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
> MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
> card->ext_csd.device_life_time_est_typ_a,
> @@ -838,6 +839,7 @@ static struct attribute *mmc_std_attrs[] = {
> &dev_attr_name.attr,
> &dev_attr_oemid.attr,
> &dev_attr_prv.attr,
> + &dev_attr_rev.attr,
> &dev_attr_pre_eol_info.attr,
> &dev_attr_life_time.attr,
> &dev_attr_serial.attr,
> --
> 2.15.0.rc0.271.g36b669edcc-goog
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-20 10:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 17:46 [PATCHv3 1/1] mmc: core: export emmc revision Jin Qian
2017-10-13 6:57 ` Jisheng Zhang
2017-10-13 12:38 ` Linus Walleij
2017-10-20 10:02 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox