From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755342AbdJMG5t (ORCPT ); Fri, 13 Oct 2017 02:57:49 -0400 Received: from mail-sn1nam02on0068.outbound.protection.outlook.com ([104.47.36.68]:10863 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751418AbdJMG5q (ORCPT ); Fri, 13 Oct 2017 02:57:46 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jisheng.Zhang@synaptics.com; Date: Fri, 13 Oct 2017 14:57:18 +0800 From: Jisheng Zhang To: Jin Qian Cc: Ulf Hansson , Jin Qian , Shawn Lin , Adrian Hunter , Linus Walleij , Jaehoon Chung , Uri Yanai , Chanho Min , Jungseung Lee , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCHv3 1/1] mmc: core: export emmc revision Message-ID: <20171013145718.390bc4ef@xhacker.debian> In-Reply-To: <20171012174703.44680-1-jinqian@android.com> References: <20171012174703.44680-1-jinqian@android.com> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Originating-IP: [124.74.246.114] X-ClientProxiedBy: SG2PR0601CA0014.apcprd06.prod.outlook.com (10.170.128.24) To BY2PR0301MB0759.namprd03.prod.outlook.com (10.160.63.27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73ad6cf2-223a-43cb-9db5-08d51207b386 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BY2PR0301MB0759; X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0759;3:MmKSWrLPPNqgJ0dwCFpUCf/DiUQ25If7kKz3GprqKoxrmPMAFm6OeLGdWuXLXHBqZT0guupSSmSJcTBq6TKSOLkbCJr9WVF0BMliCAgox7C+0gqfSi/6FvsOL1eToe+QHO0j4xC0lBKwfZj3/gB6O52IEqJiUTLbwEUty6RNqfdpCGPYqNUSXbg/Z2pkbu4ACwJ7WV2khTMBh7ktVgjCiCG1Osa0wh34UZ61hWDcZgfTFw6Nr7HIgbh9tlpZZx4Q;25:nDZzDW8F7N4SkbPL1APglLzSl0Frzt6R3nwgBR0JiOD5b08Ibul/jBSr1OM0tQfXsIFULeybCd8pZoyaXg+XBqUFhFzmUyB+DWVDxOWBYsiDYRFdVGdcwOC81S8382+btz6gulLbPYvMEk+VSxL8wSXNJlsbGCIw7D6Gp3fM7iCoWJ8XxRYaYoPt0SWrY6AWLHJYMb2qJ/mdBzL+iWsePeK4FPHyA8aB3St1TtVjWCkmDENFtg5iM8UDeLXzLtrMuee5a1dkF2bDA4pxBJbOjxlU9pZx0ZF4NP/Es0cSX3yXEASdawbAOnFUkGLKyvNFCM46AEl/F9Z8R5o3gkbvu09D8IhxN1xULOrQhbLrde0=;31:dzajNM1/gpQ4Bt5VcQWUH8u9IVxFKieIFaB+3u+OBwZYrt0061iTznzjNSNMrJhmgaM/Gi+YHUz5ue3n8MRLgcTJQdC5pflB5Vuo+MxX97GtlJdgArJ6+8BdPymI8TVYGpKOGzX/X/Ocr7tDLrqm0hgsg9A1rWm3zeQgN0/kT6W28YDg92pPN0FEGcnWKkcUKN0dKUMY7x8BNW0SGgk+evfQCw/JvTJ4MDyWiZHv1eI= X-MS-TrafficTypeDiagnostic: BY2PR0301MB0759: X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0759;20:PYFZ6H3T3k9KmH4HhOb3QtBblv1A/kRLXcLgBQ4hx/RFDDrhtIL+EcOJxSSNQEh1NTe3xV3F0TFy8AyJN5T2vZ6+PL8eOuqMGVtu+/NlbXt+FUdHko4fW113flB3ilg1spA5jSWCvirqU1B/p62TgXn3sRWVt7corxvwhd85DGF7Vn7nBMQp+904OMJ9jxp1wklc78sWxMw7hi3kP8X7rGxo7EuIwNxG1J9u7M92lXSbkztiJTyjVgjNGY9S5lS+bwOcfmNW3Ice+Sl8utlyRrvuec0ETeCJjKFaD7QRjj/Wu9iheVmTNLoLo70ShaW6wgxJk2p110JC/16SODGsCyaK6GpL+rorpMGz/FhvDOqDTiB8adUOFTyYb7kqdDHyrc/5nSj21azmAF2Z1KnchrUQAjBMxkILVfFnL+8WNEs=;4:dFaU3k5EjvqElaekh6BlT/KIHJjzoDP6stgMzot1f92IgyRxf0aZMqjDvfQo4k5UgHk3f1OwOjJelyT6eWK2vW1F4tIgdKiCijj9mcDF5sQS51wdJ7OBFB8YkylvJIuO7x2o4lMozMijFd47eGSqtyQPGFUfK+GbIagQDCJ1U143NbJOD6Xrc7eJ5+1xpCb0wgcWpIe6/MRmYcYIiyE/pBbVLOWxkA54gNMPE/gqzA4o2xmsXep+Kbgo3gcBUG1nmb7M2aMigxAYaXm8zPWx/lp/ZGH+oudTkEOH/Y2QdJ3ByHEMQQgfbIhlBhnu/F9mwu0Gd0SlJOGnKdvTbh0Vkg== X-Exchange-Antispam-Report-Test: UriScan:(211936372134217)(153496737603132); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(920507026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123558100)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR0301MB0759;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR0301MB0759; X-Forefront-PRVS: 04599F3534 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39830400002)(189002)(50944005)(54534003)(24454002)(51344004)(199003)(76176999)(229853002)(6666003)(189998001)(47776003)(66066001)(4326008)(54906003)(86362001)(305945005)(25786009)(8676002)(8656003)(72206003)(3846002)(23726003)(6116002)(1076002)(7736002)(16526018)(34040400001)(50986999)(478600001)(8936002)(81166006)(101416001)(81156014)(50466002)(97736004)(5660300001)(230700001)(2906002)(316002)(33646002)(68736007)(6506006)(106356001)(6916009)(50226002)(7416002)(105586002)(53936002)(6246003)(55016002)(2950100002)(9686003)(39210200001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR0301MB0759;H:xhacker.debian;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR0301MB0759;23:IUdSFNsqAt3L+AGlSDi7lzA12+aLF6i84oGCiVw?= =?us-ascii?Q?3SS2VNbE1DhAJ6oXHXVb4leKogNMGNczZocK0y6uIY5yXCbgxC7RtyQjGoSP?= =?us-ascii?Q?MOyWIKDRbk36TJGvYyE3Wti20rdgVF2xv08c5hl+kv6NnLoGo8/DvZ5YTdBH?= =?us-ascii?Q?RRUnPQzo+bztaD3ien2OPi0eGT/9K9+WSb3sKpDStW8vqxPGVCJfIAAD6vjJ?= =?us-ascii?Q?ebNsVGhVdUJtD5RDKafth7ZmfGThcKww4N0MNfQfscO+nBtyI7fbcuZo2s+5?= =?us-ascii?Q?FJT6Z0WpFgdsRvpY1fhe8G9WtPPSHRxWDUYkhAlQOgQn+ugFJpj6iwfoN7bk?= =?us-ascii?Q?yTS7tv1bRDMGXc43cU9NnMXX5aaYwPvtp2LF0gjPaJRXEhd3vPhPEol+b78E?= =?us-ascii?Q?uMELCzptwBfbMEl+CytvjDToam80YqYafzo+y+jZNN8YG0GuQSH5grklYU18?= =?us-ascii?Q?RkA9kVw2mErjUZqGcLgp0LMoPj96a/OQjX4szz5ipSOyB4hDC3wu3Bn6rbZD?= =?us-ascii?Q?uNeFci1nZmMU2mGogWwnRUI7tE8YXFuIEX8aE5h4M26xvf//+oZLRZcJB4Bf?= =?us-ascii?Q?exrhZEScIIjHVP1REXVOCLzmeTrYo3DcgkrHzukkpRLjUG626yDfSfROf0Cw?= =?us-ascii?Q?xXonQoHl0nUjblN+7UyNo6TYtC55+pefYImq+mCrT76BjY68qQDfn+16PR7D?= =?us-ascii?Q?HYIsSX0yvW5+ofRK3kBQmqn6+rVjH4aBJ7g4iXU7PLNreGUFlNVckZimoLZP?= =?us-ascii?Q?Z4bSJwX+44YeGywwddwRn6zdK0ARNiftX9YQnEf46uXu1zBgShMge1MgxS1Z?= =?us-ascii?Q?GI01Q22q3FBmc5JPgeEv1qC1g5IQWfomQV2w9yGVFMVC/qO52F9RpktjnDXq?= =?us-ascii?Q?awjk75WiXTnVoSmkMlhiO4XsfjHEJDFsUOeOQkTjyMRFbQd+W631DzmQGQcB?= =?us-ascii?Q?wlyyaAF80zQa4jCnyzd3S+SokMPJWyAvoz0D7c+TegT+/xE8sWVxydOZ2eKI?= =?us-ascii?Q?badGhJ1Va1/2XNfY0q6RCk6EJ894ppupFO613nneEEKfu0XkGSJi46puQ8NI?= =?us-ascii?Q?z3AN3VPyrZzfe7h8k2xw8ccLiaXg0oB+lbg7usPaECzhjSFUWXefmksk3RHQ?= =?us-ascii?Q?iWY8KI72Glr/nt4KpXKqwybTblVfc+NOJuXJSq61qdxIKiNc+KECu/cpjiTi?= =?us-ascii?Q?dpQzxmh+FX02ET8WuCDIUr0RvFHnNnIj6wDSV3qom5L0j0NcNt4uzAJvH2rz?= =?us-ascii?Q?1jrtHCCV0Yil5IjfD0OkysnP17u3mwYNrBVx1t+Kzhs4xZ3ql7HKQDM7MP3Y?= =?us-ascii?Q?8csYFKK9Iju9YBUWgLTdkhyw=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR0301MB0759;6:doguw5jRS5YSB+I63bzQiTUCYdqP1klYUUZaSG0JwiKallC5bWAG6OBQ1czsB8vVOqcL4nQ95uZP4DaXgM6VdOQ5SNM1IflwEQ41uInxPczmvIInq+awI6QyXPCB+yHAoRYZpWIsEePkVHpdXjMDQ9oxNZIYY8tFs50MSqUjoNN17LImP0VSAQ22bbfyy8u0ItaOLszNeBGLuY3+caUVFT7OmfnD137CrH9u9/9tDZsq7onOUnzBGZN/pOF+dW+FkUq38IHytuv5sfoqKL+A2I8BZkNDaSOkgClyvXrMrBFYS0hsRSk1dikPZmq6c6PeF0JzYYmwbEvkjG2I4RuEcw==;5:mzUxYsphrMuHJPBUOkxsJ/m/0JTnAYAAzit7MIz3tPl1abeqLhKBJqocpiyLi2stRA4JE93DNCcB7JYWgNBqfB+2egMs1WmLNnjLpWVZ6dU6zhsDN5rAQUYHN/nDtoOZjkWrw+pPSGNmDZujwhciag==;24:zbxYXX3KZa0NAj08lYzG+K8ZKhcfHywrFc4GaRNDPvdgdRdZu+NV6AtX2qpHRwVqbCINiZmnVF8vICbb0n8Ao+ZeQb0VFxafc/0ptcRaepM=;7:AVKYvLO37oI884uFep7H1OSbVusmKtX1NwRvKKm2TDKS3c4qxN3yA34uuZcFH4SJmE5g/vJIc+D9cPhm92IQ+7tFrJCljFOiROayREd3YO/gvrwThf4VGY62vuc5Qo9/Jmkwqa8+QH1U/UEblee/97x2mR6532iIurpzXjYoZFMBcLkvv4wpaBw5OehrMfODzOegiBc0YnCUPmS7B7vlBg+hYPyuGhYx4iEUqkDFX0U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 06:57:38.4589 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0301MB0759 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Oct 2017 10:46:59 -0700 Jin Qian wrote: > From: Jin Qian > > Expose emmc revision as part of device attributes. > > Signed-off-by: Jin Qian > --- A trivial point: when you send newer version, could you add change log so that it's clearly expressed what's updated/addressed. > Documentation/ABI/testing/sysfs-bus-mmc | 4 ++++ > drivers/mmc/core/mmc.c | 2 ++ > 2 files changed, 6 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-mmc > > diff --git a/Documentation/ABI/testing/sysfs-bus-mmc b/Documentation/ABI/testing/sysfs-bus-mmc > new file mode 100644 > index 000000000000..519f028d19cc > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-mmc > @@ -0,0 +1,4 @@ > +What: /sys/bus/mmc/devices/.../rev > +Date: October 2017 > +Contact: Jin Qian > +Description: Extended CSD revision number > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index 36217ad5e9b1..4aa4cfb2c9e1 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -780,6 +780,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid); > MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name); > MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid); > MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv); > +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev); > MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info); > MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n", > card->ext_csd.device_life_time_est_typ_a, > @@ -838,6 +839,7 @@ static struct attribute *mmc_std_attrs[] = { > &dev_attr_name.attr, > &dev_attr_oemid.attr, > &dev_attr_prv.attr, > + &dev_attr_rev.attr, > &dev_attr_pre_eol_info.attr, > &dev_attr_life_time.attr, > &dev_attr_serial.attr,