From: Andi Kleen <ak@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Jonathan McDowell <noodles@earth.li>
Subject: Re: [PATCH v9 2/5] x86/cpuid: Add generic table for cpuid dependencies
Date: Fri, 13 Oct 2017 09:36:36 -0700 [thread overview]
Message-ID: <20171013163636.GP5109@tassilo.jf.intel.com> (raw)
In-Reply-To: <20171013053005.cj5vhqehkwlnhyla@gmail.com>
> > I was looking at that as well and decided that we preferrably have a
> > compressed data structure. The code which walks the table is hardly
> > performance critical and the difference in text size is marginal.
>
> So the code should all be __init (once that is fixed), hence data and text size
> literally does not matter - it gets freed.
It's difficult to make the code __init because it's part of the CPU initialization and
the CPU initialization is called from CPU hotplug.
It shouldn't do anything after initial boot however, but it's difficult to tell
that to the dependency checker.
In theory it would be possible to restructure cpu initialization to avoid this,
but I suspect it would be rather large and intrusive and probably not worth
it for a couple hundred bytes.
I removed the shorts.
-Andi
next prev parent reply other threads:[~2017-10-13 16:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 0:03 Support generic disabling of all XSAVE features Andi Kleen
2017-10-07 0:03 ` [PATCH v9 1/5] x86/xsave: Move xsave initialization to after parsing early parameters Andi Kleen
2017-10-12 7:18 ` Ingo Molnar
2017-10-07 0:03 ` [PATCH v9 2/5] x86/cpuid: Add generic table for cpuid dependencies Andi Kleen
2017-10-08 8:35 ` Thomas Gleixner
2017-10-12 8:07 ` Ingo Molnar
2017-10-12 8:16 ` Ingo Molnar
2017-10-13 17:46 ` Andi Kleen
2017-10-12 15:13 ` Thomas Gleixner
2017-10-12 22:01 ` Andi Kleen
2017-10-13 5:30 ` Ingo Molnar
2017-10-13 16:36 ` Andi Kleen [this message]
2017-10-12 22:12 ` Andi Kleen
2017-10-07 0:03 ` [PATCH v9 3/5] x86/cpuid: Make clearcpuid an early param Andi Kleen
2017-10-12 8:09 ` Ingo Molnar
2017-10-07 0:03 ` [PATCH v9 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling Andi Kleen
2017-10-08 8:34 ` Thomas Gleixner
2017-10-12 8:11 ` Ingo Molnar
2017-10-13 17:48 ` Andi Kleen
2017-10-07 0:03 ` [PATCH v9 5/5] x86/xsave: Remove the explicit clearing of XSAVE dependend features Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013163636.GP5109@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=noodles@earth.li \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox