From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752339AbdJMRFS (ORCPT ); Fri, 13 Oct 2017 13:05:18 -0400 Received: from muru.com ([72.249.23.125]:44108 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdJMRFR (ORCPT ); Fri, 13 Oct 2017 13:05:17 -0400 Date: Fri, 13 Oct 2017 10:05:13 -0700 From: Tony Lindgren To: Benoit Parrot Cc: Tero Kristo , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [Patch 5/6] ARM: DRA7: hwmod: Add VPE nodes Message-ID: <20171013170513.GM4394@atomide.com> References: <20171012192719.15193-1-bparrot@ti.com> <20171012192719.15193-6-bparrot@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012192719.15193-6-bparrot@ti.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Benoit Parrot [171012 12:28]: > +static struct omap_hwmod_class_sysconfig dra7xx_vpe_sysc = { > + .sysc_offs = 0x0010, > + .sysc_flags = (SYSC_HAS_MIDLEMODE | SYSC_HAS_SIDLEMODE), > + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | > + MSTANDBY_FORCE | MSTANDBY_NO | > + MSTANDBY_SMART), > + .sysc_fields = &omap_hwmod_sysc_type2, > +}; I think checkpatch.pl --strict would complain about unnecessary parentheses, might as well check the whole series while at it. Regards, Tony