* [PATCH] bus: ti-sysc: mark PM functions as __maybe_unused
@ 2017-10-13 9:25 Arnd Bergmann
2017-10-13 17:27 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-10-13 9:25 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Arnd Bergmann, linux-kernel
The new bus driver causes a harmless compile-time warning when
CONFIG_PM is disabled:
drivers/bus/ti-sysc.c:440:12: error: 'sysc_runtime_resume' defined but not used [-Werror=unused-function]
static int sysc_runtime_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~
drivers/bus/ti-sysc.c:421:12: error: 'sysc_runtime_suspend' defined but not used [-Werror=unused-function]
static int sysc_runtime_suspend(struct device *dev)
^~~~~~~~~~~~~~~~~~~~
This marks the two unused functions as __maybe_unused to shut up
that warning.
Fixes: 0eecc636e5a2 ("bus: ti-sysc: Add minimal TI sysc interconnect target driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/bus/ti-sysc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
index 9b3cb278ce41..8b95d0f0c319 100644
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -418,7 +418,7 @@ static void sysc_show_registers(struct sysc *ddata)
buf);
}
-static int sysc_runtime_suspend(struct device *dev)
+static int __maybe_unused sysc_runtime_suspend(struct device *dev)
{
struct sysc *ddata;
int i;
@@ -437,7 +437,7 @@ static int sysc_runtime_suspend(struct device *dev)
return 0;
}
-static int sysc_runtime_resume(struct device *dev)
+static int __maybe_unused sysc_runtime_resume(struct device *dev)
{
struct sysc *ddata;
int i, error;
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] bus: ti-sysc: mark PM functions as __maybe_unused
2017-10-13 9:25 [PATCH] bus: ti-sysc: mark PM functions as __maybe_unused Arnd Bergmann
@ 2017-10-13 17:27 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2017-10-13 17:27 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-kernel
* Arnd Bergmann <arnd@arndb.de> [171013 02:27]:
> The new bus driver causes a harmless compile-time warning when
> CONFIG_PM is disabled:
>
> drivers/bus/ti-sysc.c:440:12: error: 'sysc_runtime_resume' defined but not used [-Werror=unused-function]
> static int sysc_runtime_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~
> drivers/bus/ti-sysc.c:421:12: error: 'sysc_runtime_suspend' defined but not used [-Werror=unused-function]
> static int sysc_runtime_suspend(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~
>
> This marks the two unused functions as __maybe_unused to shut up
> that warning.
Thanks applying into omap-for-v4.15/ti-sysc.
Regards,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-13 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-13 9:25 [PATCH] bus: ti-sysc: mark PM functions as __maybe_unused Arnd Bergmann
2017-10-13 17:27 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox