From: Andi Kleen <ak@linux.intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v9 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling
Date: Fri, 13 Oct 2017 10:48:50 -0700 [thread overview]
Message-ID: <20171013174850.GR5109@tassilo.jf.intel.com> (raw)
In-Reply-To: <20171012081126.g4shmny3qumwzf4m@gmail.com>
> > + /*
> > + * Clear XSAVE features that are disabled in the normal CPUID.
> > + */
> > + for (i = 0; i < ARRAY_SIZE(xsave_cpuid_features); i++) {
> > + if (!boot_cpu_has(xsave_cpuid_features[i]))
> > + xfeatures_mask &= ~BIT(i);
> > + }
> > +
> > xfeatures_mask &= fpu__get_supported_xfeatures_mask();
> >
> > /* Enable xstate instructions to be able to continue with initialization: */
>
> This patch has similar problems to the ones I reported against 2/5.
I'm not clear what I'm supposed to change here. The array cannot be __initdata
because it is used at cpu hotplug. Nothing else seems to apply.
-Andi
next prev parent reply other threads:[~2017-10-13 17:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-07 0:03 Support generic disabling of all XSAVE features Andi Kleen
2017-10-07 0:03 ` [PATCH v9 1/5] x86/xsave: Move xsave initialization to after parsing early parameters Andi Kleen
2017-10-12 7:18 ` Ingo Molnar
2017-10-07 0:03 ` [PATCH v9 2/5] x86/cpuid: Add generic table for cpuid dependencies Andi Kleen
2017-10-08 8:35 ` Thomas Gleixner
2017-10-12 8:07 ` Ingo Molnar
2017-10-12 8:16 ` Ingo Molnar
2017-10-13 17:46 ` Andi Kleen
2017-10-12 15:13 ` Thomas Gleixner
2017-10-12 22:01 ` Andi Kleen
2017-10-13 5:30 ` Ingo Molnar
2017-10-13 16:36 ` Andi Kleen
2017-10-12 22:12 ` Andi Kleen
2017-10-07 0:03 ` [PATCH v9 3/5] x86/cpuid: Make clearcpuid an early param Andi Kleen
2017-10-12 8:09 ` Ingo Molnar
2017-10-07 0:03 ` [PATCH v9 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling Andi Kleen
2017-10-08 8:34 ` Thomas Gleixner
2017-10-12 8:11 ` Ingo Molnar
2017-10-13 17:48 ` Andi Kleen [this message]
2017-10-07 0:03 ` [PATCH v9 5/5] x86/xsave: Remove the explicit clearing of XSAVE dependend features Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013174850.GR5109@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox