From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753345AbdJMTuk (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Oct 2017 15:50:40 -0400
Received: from mail.kernel.org ([198.145.29.99]:46032 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751906AbdJMTuj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Oct 2017 15:50:39 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6BCA21483
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org
Date: Fri, 13 Oct 2017 16:50:36 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Andi Kleen <andi@firstfloor.org>, "Jin, Yao" <yao.jin@linux.intel.com>,
        "Wangnan (F)" <wangnan0@huawei.com>,
        "Du, Changbin" <changbin.du@intel.com>
Subject: Re: [PATCH 9/9] perf tools: Unwind properly location after REJECT
Message-ID: <20171013195036.GB5311@kernel.org>
References: <20171013083736.15037-1-jolsa@kernel.org>
 <20171013083736.15037-10-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171013083736.15037-10-jolsa@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Fri, Oct 13, 2017 at 10:37:36AM +0200, Jiri Olsa escreveu:
> We have defined YY_USER_ACTION to keep trace of the column
> location during events parsing, but we need to clean it up
> when we call REJECT.
> 
> When REJECT is called, the lexer shrinks the text and re-runs
> the matching, so we need to address it in resuming the previous
> location value.

What is this fixing? Please state that, below I show what it is breaking
:-/

Before:

[root@jouet ~]# perf trace --no-syscalls -e ~acme/bpf/sys_read.c/max-stack=5/ sleep 1
bpf: builtin compilation failed: -95, try external compiler
     0.000 perf_bpf_probe:func:(ffffffffbb2634e0))
                                       sys_read ([kernel.kallsyms])
                                       entry_SYSCALL_64_fastpath ([kernel.kallsyms])
                                       __read (/usr/lib64/ld-2.25.so)
                                       _dl_map_object (/usr/lib64/ld-2.25.so)

After:

[root@jouet ~]# perf trace --no-syscalls -e ~acme/bpf/sys_read.c/max-stack=5/ sleep 1
event syntax error: '/home/acme/bpf/sys_read.c/max-stack=5/'
                     \___ parser error
Run 'perf list' for a list of valid events

 Usage: perf trace [<options>] [<command>]
    or: perf trace [<options>] -- <command> [<options>]
    or: perf trace record [<options>] [<command>]
    or: perf trace record [<options>] -- <command> [<options>]

    -e, --event <event>   event/syscall selector. use 'perf list' to list available events
[root@jouet ~]#