Re: [PATCH] printk: Remove superfluous memory barriers from printk_safe

Petr Mladek
2017-10-12T09:34:47Z

On Wed 2017-10-11 12:46:47, Steven Rostedt wrote:
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> The variable printk_safe_irq_ready is set and never cleared at system
> boot up, when there's only one CPU active. It is set before other
> CPUs come on line. Also, it is extremely unlikely that an NMI would
> trigger this early in boot up (which I wonder why we even have this
> variable at all).
>
> Also mark the printk_safe_irq_ready as read mostly, as it is set at
> system boot up, and never touched again.
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Great catch! It makes perfect sense:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr