* [PATCH] ALSA: pcm: remove redundant variable runtime
@ 2017-10-15 21:06 Colin King
2017-10-16 11:36 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-10-15 21:06 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Takashi Sakamoto, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
An earlier commit removed the access to variable runtime
and we are now left with unused variable that is redundant,
so remove it.
Cleans up the clang warning: Value stored to 'runtime' is never read
Fixes: e11f0f90a626 ("ALSA: pcm: remove SNDRV_PCM_IOCTL1_INFO internal command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/core/pcm_native.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 2fec2feac387..a4d92e46c459 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -195,7 +195,6 @@ EXPORT_SYMBOL_GPL(snd_pcm_stream_unlock_irqrestore);
int snd_pcm_info(struct snd_pcm_substream *substream, struct snd_pcm_info *info)
{
- struct snd_pcm_runtime *runtime;
struct snd_pcm *pcm = substream->pcm;
struct snd_pcm_str *pstr = substream->pstr;
@@ -211,7 +210,6 @@ int snd_pcm_info(struct snd_pcm_substream *substream, struct snd_pcm_info *info)
info->subdevices_count = pstr->substream_count;
info->subdevices_avail = pstr->substream_count - pstr->substream_opened;
strlcpy(info->subname, substream->name, sizeof(info->subname));
- runtime = substream->runtime;
return 0;
}
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: pcm: remove redundant variable runtime
2017-10-15 21:06 [PATCH] ALSA: pcm: remove redundant variable runtime Colin King
@ 2017-10-16 11:36 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2017-10-16 11:36 UTC (permalink / raw)
To: Colin King
Cc: alsa-devel, Jaroslav Kysela, Takashi Sakamoto, kernel-janitors,
linux-kernel
On Sun, 15 Oct 2017 23:06:44 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> An earlier commit removed the access to variable runtime
> and we are now left with unused variable that is redundant,
> so remove it.
>
> Cleans up the clang warning: Value stored to 'runtime' is never read
>
> Fixes: e11f0f90a626 ("ALSA: pcm: remove SNDRV_PCM_IOCTL1_INFO internal command")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 11:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-15 21:06 [PATCH] ALSA: pcm: remove redundant variable runtime Colin King
2017-10-16 11:36 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).