From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752045AbdJPGBA (ORCPT <rfc822;w@1wt.eu>);
        Mon, 16 Oct 2017 02:01:00 -0400
Received: from mga09.intel.com ([134.134.136.24]:22307 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751994AbdJPGA6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 16 Oct 2017 02:00:58 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,385,1503385200"; 
   d="scan'208";a="1206197586"
Date: Mon, 16 Oct 2017 11:35:10 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: Chintan Patel <chintan.m.patel@intel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Jeeja KP <jeeja.kp@intel.com>,
        "guneshwor.o.singh@intel.com" <guneshwor.o.singh@intel.com>,
        Shreyas NC <shreyas.nc@intel.com>,
        Takashi Sakamoto <takashi.sakamoto@miraclelinux.com>,
        Ramesh Babu <ramesh.babu@intel.com>,
        Dharageswari R <dharageswari.r@intel.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology
 loading
Message-ID: <20171016060510.GF30097@localhost>
References: <1507826678-25509-1-git-send-email-chintan.m.patel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1507826678-25509-1-git-send-email-chintan.m.patel@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 12, 2017 at 09:44:37AM -0700, Chintan Patel wrote:
> In case of failure in loading customize topology firmware, dfw_sst.bin
> gets loaded. However, current log provides this message as error even
> after successfully falling back to default topology "dfw_sst.bin".
> 
> Hence to convey proper message, changing log level and message.

Acked-By: Vinod Koul <vinod.koul@intel.com>

> Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
> ---
> Changes in v2:
> Addressing review comments from Takashi Iwai by changing
> loglevel as info
> 
> sound/soc/intel/skylake/skl-topology.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
> index 22f768ca3c73..12f383fd7c39 100644
> --- a/sound/soc/intel/skylake/skl-topology.c
> +++ b/sound/soc/intel/skylake/skl-topology.c
> @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
>  
>  	ret = request_firmware(&fw, skl->tplg_name, bus->dev);
>  	if (ret < 0) {
> -		dev_err(bus->dev, "tplg fw %s load failed with %d\n",
> +		dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
>  				skl->tplg_name, ret);
>  		ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
>  		if (ret < 0) {
> -- 
> 1.9.1
> 

-- 
~Vinod