From: Vinod Koul <vinod.koul@intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: nbpfaxi: mark expected switch fall-through
Date: Mon, 16 Oct 2017 12:18:18 +0530 [thread overview]
Message-ID: <20171016064818.GM30097@localhost> (raw)
In-Reply-To: <20171013201719.GA7498@embeddedor.com>
On Fri, Oct 13, 2017 at 03:17:19PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/dma/nbpfaxi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c
> index d3f918a..68a3a83 100644
> --- a/drivers/dma/nbpfaxi.c
> +++ b/drivers/dma/nbpfaxi.c
> @@ -479,6 +479,7 @@ static size_t nbpf_xfer_size(struct nbpf_device *nbpf,
>
> default:
> pr_warn("%s(): invalid bus width %u\n", __func__, width);
> + /* fall through */
can we add more details why we are falling thru and why this value is sane
default..
> case DMA_SLAVE_BUSWIDTH_1_BYTE:
> size = burst;
> }
> --
> 2.7.4
>
--
~Vinod
next prev parent reply other threads:[~2017-10-16 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 20:17 [PATCH] dmaengine: nbpfaxi: mark expected switch fall-through Gustavo A. R. Silva
2017-10-16 6:48 ` Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-02 18:06 [PATCH] dmaengine: nbpfaxi: Mark " Gustavo A. R. Silva
2018-07-06 5:56 ` Vinod
2018-07-06 11:47 ` Gustavo A. R. Silva
2018-07-09 11:32 ` Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016064818.GM30097@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=garsilva@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox