From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751728AbdJPGoF (ORCPT ); Mon, 16 Oct 2017 02:44:05 -0400 Received: from mga01.intel.com ([192.55.52.88]:6275 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbdJPGoE (ORCPT ); Mon, 16 Oct 2017 02:44:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,385,1503385200"; d="scan'208";a="163523842" Date: Mon, 16 Oct 2017 12:18:18 +0530 From: Vinod Koul To: "Gustavo A. R. Silva" Cc: Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: nbpfaxi: mark expected switch fall-through Message-ID: <20171016064818.GM30097@localhost> References: <20171013201719.GA7498@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171013201719.GA7498@embeddedor.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 13, 2017 at 03:17:19PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/dma/nbpfaxi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/nbpfaxi.c b/drivers/dma/nbpfaxi.c > index d3f918a..68a3a83 100644 > --- a/drivers/dma/nbpfaxi.c > +++ b/drivers/dma/nbpfaxi.c > @@ -479,6 +479,7 @@ static size_t nbpf_xfer_size(struct nbpf_device *nbpf, > > default: > pr_warn("%s(): invalid bus width %u\n", __func__, width); > + /* fall through */ can we add more details why we are falling thru and why this value is sane default.. > case DMA_SLAVE_BUSWIDTH_1_BYTE: > size = burst; > } > -- > 2.7.4 > -- ~Vinod