From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842AbdJPHpT (ORCPT ); Mon, 16 Oct 2017 03:45:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47976 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751743AbdJPHpS (ORCPT ); Mon, 16 Oct 2017 03:45:18 -0400 Date: Mon, 16 Oct 2017 09:45:25 +0200 From: Greg KH To: =?utf-8?B?5Yav6ZSQ?= Cc: Lee Jones , "devel@driverdev.osuosl.org" , "ricky_wu@realtek.com" , "linux-kernel@vger.kernel.org" Subject: Re: =?utf-8?B?562U5aSN?= =?utf-8?Q?=3A?= [PATCH] staging: rtsx: Add support for RTS5260 Message-ID: <20171016074525.GA3044@kroah.com> References: <1507884635-3134-1-git-send-email-rui_feng@realsil.com.cn> <20171013092659.GA28241@kroah.com> <20171013095422.6mql3mso77duoiko@dell> <20171013095944.GA23569@kroah.com> <2A308283684ECD4B896628E09AF5361E01A739CE@RS-MBS01.realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2A308283684ECD4B896628E09AF5361E01A739CE@RS-MBS01.realsil.com.cn> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 05:58:12AM +0000, 冯锐 wrote: > > On Fri, Oct 13, 2017 at 10:54:22AM +0100, Lee Jones wrote: > > > On Fri, 13 Oct 2017, Greg KH wrote: > > > > > > > On Fri, Oct 13, 2017 at 04:50:35PM +0800, rui_feng@realsil.com.cn wrote: > > > > > From: rui_feng > > > > > > > > > > Add support for new chip rts5260. > > > > > In order to support rts5260，the definitions of some internal > > > > > registers and workflow have to be modified and are different from > > > > > its predecessors and OCP function is added for RTS5260. > > > > > So we need this patch to ensure RTS5260 can work. > > > > > > > > > > Signed-off-by: Rui Feng > > > > > > > > Your from and signed-off-by name does not match :( > > > > > > > > > --- > > > > > drivers/mfd/Makefile | 4 + > > > > > drivers/mfd/rtsx_pcr.c | 127 ++++++- > > > > > drivers/mfd/rtsx_pcr.h | 12 + > > > > > drivers/staging/Kconfig | 2 + > > > > > drivers/staging/rts5260/Kconfig | 6 + > > > > > drivers/staging/rts5260/rts5260.c | 748 > > > > > ++++++++++++++++++++++++++++++++++++++ > > > > > drivers/staging/rts5260/rts5260.h | 45 +++ > > > > > include/linux/mfd/rtsx_pci.h | 234 +++++++++++- > > > > > > > > I do not see a reason why this is a staging driver. Where is the > > > > TODO file listing what needs to be done to get it out of staging? > > > > Why can it not just go into the "real" part of the kernel? > > > > > > It's not a staging driver. Rui's focus appears to be to have this > > > driver accepted into Mainline by hook or by crock. He's tried MFD, > > > Misc and now Staging! > > > > Yeah, I've watched it too :) > > > > > Background: > > > > > > There are a number of drivers in this family which currently reside in > > > MFD. These were accepted before my time. After a recent review I've > > > made the decision that these aren't MFD drivers at all. > > > > > > MFD drivers are ones which aid in registering and setting up shared > > > resources for sub-devices which reside on the same piece of silicon. > > > This driver does basically none of that. Instead it *is* the (what we > > > describe above as) sub-device. It does everything. > > > > I agree with your assessment. > > > > > In the absence of a subsystem which covers this type of device, I > > > suggested Misk as a good location to place these drivers. > > > > What type of device is this thing? I can't seem to figure that out. If we can > > determine that, then we can find the proper place for it in the kernel. > > > > Rui, what does this hardware do? What is the interface between the > > hardware and userspace that this driver is creating? > > > This driver is a pcie driver, it bridge mmc subsystem and memstick > subsystem, and it does not deal with userspace. Ok, sounds like drivers/misc/ is a good place for it. thanks, greg k-h